From: Andrew Jones <drjones@redhat.com>
To: Beata Michalska <beata.michalska@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, armbru@redhat.com, eric.auger@redhat.com,
qemu-arm@nongnu.org, imammedo@redhat.com, Dave.Martin@arm.com
Subject: Re: [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion
Date: Tue, 15 Oct 2019 12:56:28 +0200 [thread overview]
Message-ID: <20191015105628.7ln6ph5s3vpsyfuw@kamzik.brq.redhat.com> (raw)
In-Reply-To: <CADSWDztJDUEd+_7XnBPWL1bk5Xh=V_aLc1+VrP97_Ycbe3489A@mail.gmail.com>
On Tue, Oct 15, 2019 at 10:59:16AM +0100, Beata Michalska wrote:
> On Tue, 1 Oct 2019 at 14:04, Andrew Jones <drjones@redhat.com> wrote:
> > +
> > + obj = object_new(object_class_get_name(oc));
> > +
> > + if (qdict_in) {
> > + Visitor *visitor;
> > + Error *err = NULL;
> > +
> > + visitor = qobject_input_visitor_new(model->props);
> > + visit_start_struct(visitor, NULL, NULL, 0, &err);
> > + if (err) {
> > + object_unref(obj);
>
> Shouldn't we free the 'visitor' here as well ?
Yes. Good catch. So we also need to fix
target/s390x/cpu_models.c:cpu_model_from_info(), which has the same
construction (the construction from which I derived this)
>
> > + error_propagate(errp, err);
> > + return NULL;
> > + }
> > +
What about the rest of the patch? With that fixed for v6 can I
add your r-b?
Thanks,
drew
next prev parent reply other threads:[~2019-10-15 11:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 12:58 [PATCH v5 0/9] target/arm/kvm: enable SVE in guests Andrew Jones
2019-10-01 12:58 ` [PATCH v5 1/9] target/arm/monitor: Introduce qmp_query_cpu_model_expansion Andrew Jones
2019-10-15 9:59 ` Beata Michalska
2019-10-15 10:56 ` Andrew Jones [this message]
2019-10-15 11:56 ` Beata Michalska
2019-10-16 13:24 ` Beata Michalska
2019-10-16 13:50 ` Andrew Jones
2019-10-16 15:16 ` Beata Michalska
2019-10-16 16:16 ` Andrew Jones
2019-10-21 15:07 ` Beata Michalska
2019-10-22 13:43 ` Andrew Jones
2019-10-22 15:49 ` Beata Michalska
2019-10-01 12:58 ` [PATCH v5 2/9] tests: arm: Introduce cpu feature tests Andrew Jones
2019-10-01 12:58 ` [PATCH v5 3/9] target/arm: Allow SVE to be disabled via a CPU property Andrew Jones
2019-10-01 12:58 ` [PATCH v5 4/9] target/arm/cpu64: max cpu: Introduce sve<N> properties Andrew Jones
2019-10-01 17:47 ` Richard Henderson
2019-10-07 7:22 ` Auger Eric
2019-10-07 8:35 ` Alex Bennée
2019-10-07 12:41 ` Andrew Jones
2019-10-09 14:01 ` Beata Michalska
2019-10-16 8:10 ` Andrew Jones
2019-10-01 12:58 ` [PATCH v5 5/9] target/arm/kvm64: Add kvm_arch_get/put_sve Andrew Jones
2019-10-01 13:52 ` Andrew Jones
2019-10-01 13:58 ` Andrew Jones
2019-10-01 17:52 ` Richard Henderson
2019-10-07 7:22 ` Auger Eric
2019-10-01 12:58 ` [PATCH v5 6/9] target/arm/kvm64: max cpu: Enable SVE when available Andrew Jones
2019-10-01 12:58 ` [PATCH v5 7/9] target/arm/kvm: scratch vcpu: Preserve input kvm_vcpu_init features Andrew Jones
2019-10-01 12:58 ` [PATCH v5 8/9] target/arm/cpu64: max cpu: Support sve properties with KVM Andrew Jones
2019-10-01 17:58 ` Richard Henderson
2019-10-01 12:58 ` [PATCH v5 9/9] target/arm/kvm: host cpu: Add support for sve<N> properties Andrew Jones
2019-10-01 17:59 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015105628.7ln6ph5s3vpsyfuw@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=Dave.Martin@arm.com \
--cc=armbru@redhat.com \
--cc=beata.michalska@linaro.org \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.