From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Stephen Boyd <swboyd@chromium.org>,
Peter Huewe <peterhuewe@gmx.de>,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Andrey Pronin <apronin@chromium.org>,
Duncan Laurie <dlaurie@chromium.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Alexander Steffen <Alexander.Steffen@infineon.com>
Subject: Re: [PATCH v7 0/6] tpm: Add driver for cr50
Date: Wed, 16 Oct 2019 18:27:31 +0300 [thread overview]
Message-ID: <20191016152731.GD4261@linux.intel.com> (raw)
In-Reply-To: <11998737.dOvWaeisEJ@phil>
On Tue, Oct 15, 2019 at 10:23:15PM +0200, Heiko Stuebner wrote:
> Hi,
>
> Am Montag, 14. Oktober 2019, 21:56:30 CEST schrieb Jarkko Sakkinen:
> > On Fri, Oct 11, 2019 at 09:50:27AM +0200, Heiko Stübner wrote:
> > > Am Montag, 7. Oktober 2019, 00:39:00 CEST schrieb Jarkko Sakkinen:
> > > > On Fri, Sep 20, 2019 at 11:32:34AM -0700, Stephen Boyd wrote:
> > > > > This patch series adds support for the H1 secure microcontroller
> > > > > running cr50 firmware found on various recent Chromebooks. This driver
> > > > > is necessary to boot into a ChromeOS userspace environment. It
> > > > > implements support for several functions, including TPM-like
> > > > > functionality over a SPI interface.
> > > > >
> > > > > The last time this was series sent looks to be [1]. I've looked over the
> > > > > patches and review comments and tried to address any feedback that
> > > > > Andrey didn't address (really minor things like newlines). I've reworked
> > > > > the patches from the last version to layer on top of the existing TPM
> > > > > TIS SPI implementation in tpm_tis_spi.c. Hopefully this is more
> > > > > palatable than combining the two drivers together into one file.
> > > > >
> > > > > Please review so we can get the approach to supporting this device
> > > > > sorted out.
> > > > >
> > > > > [1] https://lkml.kernel.org/r/1469757314-116169-1-git-send-email-apronin@chromium.org
> > >
> > > [...]
> > >
> > > > OK, so, I put these to my master in hopes to get testing exposure.
> > > > I think the changes are in great shape now. Thank you.
> > >
> > > on a rk3399-gru-bob it works nicely for me, so
> > > Tested-by: Heiko Stuebner <heiko@sntech.de>
> >
> > Thank you! I updated my tree with your tag. Mind if I also add
> > reviewed-by's?
>
> I think I did spent enough time with the patches to warrant that, so
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Thank you!
/Jarkko
prev parent reply other threads:[~2019-10-16 15:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 18:32 [PATCH v7 0/6] tpm: Add driver for cr50 Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 1/6] dt-bindings: tpm: document properties " Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 2/6] tpm: Add a flag to indicate TPM power is managed by firmware Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 3/6] tpm: tpm_tis_spi: Introduce a flow control callback Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 4/6] tpm: tpm_tis_spi: Support cr50 devices Stephen Boyd
2019-10-06 22:32 ` Jarkko Sakkinen
2020-02-03 9:13 ` Alexander Steffen
2020-02-04 0:37 ` Stephen Boyd
2020-02-04 7:15 ` Alexander Steffen
2020-02-04 12:00 ` Jarkko Sakkinen
2019-09-20 18:32 ` [PATCH v7 5/6] tpm: tpm_tis_spi: Cleanup includes Stephen Boyd
2019-10-06 22:34 ` Jarkko Sakkinen
2019-09-20 18:32 ` [PATCH v7 6/6] tpm: tpm_tis_spi: Drop THIS_MODULE usage from driver struct Stephen Boyd
2019-10-06 22:35 ` Jarkko Sakkinen
2019-10-06 22:39 ` [PATCH v7 0/6] tpm: Add driver for cr50 Jarkko Sakkinen
2019-10-11 7:50 ` Heiko Stübner
2019-10-14 19:56 ` Jarkko Sakkinen
2019-10-15 20:23 ` Heiko Stuebner
2019-10-16 15:27 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016152731.GD4261@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=apronin@chromium.org \
--cc=arnd@arndb.de \
--cc=dlaurie@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.