From: Ira Weiny <ira.weiny@intel.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@lst.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/5] fs/xfs: Isolate the physical DAX flag from effective
Date: Mon, 21 Oct 2019 10:40:26 -0700 [thread overview]
Message-ID: <20191021174025.GA23024@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20191021002621.GC8015@dread.disaster.area>
On Mon, Oct 21, 2019 at 11:26:21AM +1100, Dave Chinner wrote:
> On Sun, Oct 20, 2019 at 08:59:32AM -0700, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > xfs_ioctl_setattr_dax_invalidate() currently checks if the DAX flag is
> > changing as a quick check.
> >
> > But the implementation mixes the physical (XFS_DIFLAG2_DAX) and
> > effective (S_DAX) DAX flags.
>
> More nuanced than that.
>
> The idea was that if the mount option was set, clearing the
> per-inode flag would override the mount option. i.e. the mount
> option sets the S_DAX flag at inode instantiation, so using
> FSSETXATTR to ensure the FS_XFLAG_DAX is not set would override the
> mount option setting, giving applications a way of guranteeing they
> aren't using DAX to access the data.
At LSF/MM we discussed keeping the mount option as a global "chicken bit" as
described by Matt Wilcox[1]. This preserves the existing behavior of turning
it on no matter what but offers an alternative with the per-file flag.
To do what you describe above, it was suggested, by Ted I believe, that an
admin can set DAX on the root directory which will enable DAX by default
through inheritance but allow users to turn it off if they desire.
I'm concerned that all users who currently use '-o dax' will expect their
current file systems to be using DAX when those mounts occur. Their physical
inode flag is going to be 0 which, if we implement the 'turn off DAX' as you
describe will mean they will not get the behavior they expect when booting on a
new kernel.
>
> So if the mount option is going to live on, I suspect that we want
> to keep this code as it stands.
I don't think we can get rid of it soon but I would be in favor of working
toward deprecating it. Regardless I think this keeps the semantics simple WRT
the interaction of the mount and per-file flags.
Ira
[1] https://lwn.net/Articles/787973/
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
next prev parent reply other threads:[~2019-10-21 17:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 15:59 [PATCH 0/5] Enable per-file/directory DAX operations ira.weiny
2019-10-20 15:59 ` [PATCH 1/5] fs/stat: Define DAX statx attribute ira.weiny
2019-10-22 11:32 ` Boaz Harrosh
2019-10-22 16:51 ` Ira Weiny
2019-10-20 15:59 ` [PATCH 2/5] fs/xfs: Isolate the physical DAX flag from effective ira.weiny
2019-10-21 0:26 ` Dave Chinner
2019-10-21 17:40 ` Ira Weiny [this message]
2019-10-20 15:59 ` [PATCH 3/5] fs/xfs: Separate functionality of xfs_inode_supports_dax() ira.weiny
2019-10-20 15:59 ` [PATCH 4/5] fs/xfs: Clean up DAX support check ira.weiny
2019-10-20 15:59 ` [PATCH 5/5] fs/xfs: Allow toggle of physical DAX flag ira.weiny
2019-10-21 0:45 ` Dave Chinner
2019-10-21 22:49 ` Ira Weiny
2019-10-21 23:46 ` Dave Chinner
2019-11-08 13:12 ` Jan Kara
2019-11-08 13:46 ` Jan Kara
2019-11-08 19:36 ` Ira Weiny
2019-11-11 16:07 ` Jan Kara
2019-11-11 23:54 ` Ira Weiny
2019-10-22 11:21 ` [PATCH 0/5] Enable per-file/directory DAX operations Boaz Harrosh
2019-10-23 13:09 ` Boaz Harrosh
2019-10-23 22:13 ` Dave Chinner
2019-10-24 2:31 ` Boaz Harrosh
2019-10-24 7:34 ` Dave Chinner
2019-10-24 14:05 ` Boaz Harrosh
2019-10-24 21:35 ` Dave Chinner
2019-10-24 23:29 ` Boaz Harrosh
2019-10-25 0:36 ` Dave Chinner
2019-10-25 1:15 ` Boaz Harrosh
2019-10-25 20:49 ` Ira Weiny
2019-10-27 22:10 ` Dave Chinner
2019-10-31 16:17 ` Ira Weiny
2019-11-01 22:47 ` Dave Chinner
2019-11-02 4:25 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021174025.GA23024@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.