Re: [Patch 5/9] arm: dts: dra72-evm-common: Add entries for the CSI2 cameras

From: Tony Lindgren <tony@atomide.com>
To: Benoit Parrot <bparrot@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>, Rob Herring <robh+dt@kernel.org>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [Patch 5/9] arm: dts: dra72-evm-common: Add entries for the CSI2 cameras
Date: Tue, 22 Oct 2019 08:44:46 -0700	[thread overview]
Message-ID: <20191022154446.GN5610@atomide.com> (raw)
In-Reply-To: <20191018154849.3127-6-bparrot@ti.com>

* Benoit Parrot <bparrot@ti.com> [191018 15:46]:
> Add device nodes for CSI2 camera board OV5640.
> Add the CAL port nodes with the necessary linkage to the ov5640 nodes.
> 
> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> ---
>  arch/arm/boot/dts/dra72-evm-common.dtsi | 35 +++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra72-evm-common.dtsi b/arch/arm/boot/dts/dra72-evm-common.dtsi
> index 8641a3d7d8ad..e4c01a67f6de 100644
> --- a/arch/arm/boot/dts/dra72-evm-common.dtsi
> +++ b/arch/arm/boot/dts/dra72-evm-common.dtsi
> @@ -187,6 +187,12 @@
>  		gpio = <&gpio5 8 GPIO_ACTIVE_HIGH>;
>  		enable-active-high;
>  	};
> +
> +	clk_ov5640_fixed: clk_ov5640_fixed {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <24000000>;
> +	};
>  };

The clock node name should be generic and not use
undescores. If there is a hidden dependency to the
clock node name here, it should be mentioned in the
patch for the non-standard use.

Regards,

Tony