All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Benoit Parrot <bparrot@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>, Rob Herring <robh+dt@kernel.org>,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [Patch 1/3] ARM: dts: am43xx: add support for clkout1 clock
Date: Tue, 22 Oct 2019 08:48:16 -0700	[thread overview]
Message-ID: <20191022154816.GO5610@atomide.com> (raw)
In-Reply-To: <20191016184954.14048-2-bparrot@ti.com>

* Benoit Parrot <bparrot@ti.com> [191016 18:47]:
> --- a/arch/arm/boot/dts/am43xx-clocks.dtsi
> +++ b/arch/arm/boot/dts/am43xx-clocks.dtsi
> @@ -704,6 +704,60 @@
>  		ti,bit-shift = <8>;
>  		reg = <0x2a48>;
>  	};
> +
> +	clkout1_osc_div_ck: clkout1_osc_div_ck {
> +		#clock-cells = <0>;
> +		compatible = "ti,divider-clock";
> +		clocks = <&sys_clkin_ck>;
> +		ti,bit-shift = <20>;
> +		ti,max-div = <4>;
> +		reg = <0x4100>;
> +	};

Here too please describe why the clock names are not generic.

Regards,

Tony

  reply	other threads:[~2019-10-22 15:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 18:49 [Patch 0/3] ARM: dts: am43x-vpfe/ov2659.patch Benoit Parrot
2019-10-16 18:49 ` Benoit Parrot
2019-10-16 18:49 ` [Patch 1/3] ARM: dts: am43xx: add support for clkout1 clock Benoit Parrot
2019-10-16 18:49   ` Benoit Parrot
2019-10-22 15:48   ` Tony Lindgren [this message]
2019-10-22 16:21     ` Benoit Parrot
2019-10-22 16:21       ` Benoit Parrot
2019-10-22 16:47       ` Tero Kristo
2019-10-22 16:47         ` Tero Kristo
2019-10-22 16:55         ` Tony Lindgren
2019-10-23 15:56           ` Tony Lindgren
2019-10-30 19:59             ` Benoit Parrot
2019-10-30 19:59               ` Benoit Parrot
2019-10-31 14:06               ` Tero Kristo
2019-10-31 14:06                 ` Tero Kristo
2019-10-31 14:25                 ` Tony Lindgren
2019-10-16 18:49 ` [Patch 2/3] ARM: dts: am437x-sk-evm: Add VPFE and OV2659 entries Benoit Parrot
2019-10-16 18:49   ` Benoit Parrot
2019-10-16 18:49 ` [Patch 3/3] ARM: dts: am43x-epos-evm: " Benoit Parrot
2019-10-16 18:49   ` Benoit Parrot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191022154816.GO5610@atomide.com \
    --to=tony@atomide.com \
    --cc=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.