From: Eduardo Habkost <ehabkost@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 00/10] image-fuzzer: Port to Python 3
Date: Tue, 22 Oct 2019 17:26:03 -0300 [thread overview]
Message-ID: <20191022202603.GB4084@habkost.net> (raw)
In-Reply-To: <20191017212927.GI4084@habkost.net>
On Thu, Oct 17, 2019 at 06:29:27PM -0300, Eduardo Habkost wrote:
> On Thu, Oct 17, 2019 at 05:11:29PM -0400, John Snow wrote:
> >
> >
> > On 10/16/19 3:24 PM, Eduardo Habkost wrote:
> > > This series ports image-fuzzer to Python 3.
> > >
> > > Eduardo Habkost (10):
> > > image-fuzzer: Open image files in binary mode
> > > image-fuzzer: Write bytes instead of string to image file
> > > image-fuzzer: Explicitly use integer division operator
> > > image-fuzzer: Use io.StringIO
> > > image-fuzzer: Use %r for all fiels at Field.__repr__()
> > > image-fuzzer: Return bytes objects on string fuzzing functions
> > > image-fuzzer: Use bytes constant for field values
> > > image-fuzzer: Encode file name and file format to bytes
> > > image-fuzzer: Run using python3
> > > image-fuzzer: Use errors parameter of subprocess.Popen()
> > >
> > > tests/image-fuzzer/qcow2/__init__.py | 1 -
> > > tests/image-fuzzer/qcow2/fuzz.py | 54 +++++++++++++-------------
> > > tests/image-fuzzer/qcow2/layout.py | 57 ++++++++++++++--------------
> > > tests/image-fuzzer/runner.py | 12 +++---
> > > 4 files changed, 61 insertions(+), 63 deletions(-)
> > >
> >
> > When I gave my try at converting this to python3 I noticed that the
> > "except OSError as e" segments used e[1] in a way that was not seemingly
> > supported.
> >
> > Did you fix that in this series or did I miss it?
>
> Good catch, I hadn't noticed that. I didn't fix it.
Separate patch sent for that issue:
https://lore.kernel.org/qemu-devel/20191021214117.18091-1-ehabkost@redhat.com/
--
Eduardo
next prev parent reply other threads:[~2019-10-22 20:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 19:24 [PATCH 00/10] image-fuzzer: Port to Python 3 Eduardo Habkost
2019-10-16 19:24 ` [PATCH 01/10] image-fuzzer: Open image files in binary mode Eduardo Habkost
2019-10-17 9:55 ` Philippe Mathieu-Daudé
2019-10-16 19:24 ` [PATCH 02/10] image-fuzzer: Write bytes instead of string to image file Eduardo Habkost
2019-10-17 9:56 ` Philippe Mathieu-Daudé
2019-10-16 19:24 ` [PATCH 03/10] image-fuzzer: Explicitly use integer division operator Eduardo Habkost
2019-10-16 19:24 ` [PATCH 04/10] image-fuzzer: Use io.StringIO Eduardo Habkost
2019-10-16 19:24 ` [PATCH 05/10] image-fuzzer: Use %r for all fiels at Field.__repr__() Eduardo Habkost
2019-10-17 21:08 ` John Snow
2019-10-16 19:24 ` [PATCH 06/10] image-fuzzer: Return bytes objects on string fuzzing functions Eduardo Habkost
2019-10-16 19:24 ` [PATCH 07/10] image-fuzzer: Use bytes constant for field values Eduardo Habkost
2019-10-17 9:55 ` Philippe Mathieu-Daudé
2019-10-16 19:24 ` [PATCH 08/10] image-fuzzer: Encode file name and file format to bytes Eduardo Habkost
2019-10-16 19:24 ` [PATCH 09/10] image-fuzzer: Run using python3 Eduardo Habkost
2019-10-16 19:24 ` [PATCH 10/10] image-fuzzer: Use errors parameter of subprocess.Popen() Eduardo Habkost
2019-10-17 21:11 ` [PATCH 00/10] image-fuzzer: Port to Python 3 John Snow
2019-10-17 21:29 ` Eduardo Habkost
2019-10-17 22:41 ` John Snow
2019-10-22 20:26 ` Eduardo Habkost [this message]
2019-10-23 15:42 ` John Snow
2019-11-05 15:35 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022202603.GB4084@habkost.net \
--to=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.