All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: "Jason Wang" <jasowang@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: [PATCH 2/3] dp8393x: fix dp8393x_receive()
Date: Sat,  2 Nov 2019 18:15:10 +0100	[thread overview]
Message-ID: <20191102171511.31881-3-laurent@vivier.eu> (raw)
In-Reply-To: <20191102171511.31881-1-laurent@vivier.eu>

address_space_rw() access size must be multiplied by the width.

This fixes DHCP for Q800 guest.

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
 hw/net/dp8393x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
index 85d3f3788e..b8c4473f99 100644
--- a/hw/net/dp8393x.c
+++ b/hw/net/dp8393x.c
@@ -833,7 +833,7 @@ static ssize_t dp8393x_receive(NetClientState *nc, const uint8_t * buf,
     } else {
         dp8393x_put(s, width, 0, 0); /* in_use */
         address_space_rw(&s->as, dp8393x_crda(s) + sizeof(uint16_t) * 6 * width,
-            MEMTXATTRS_UNSPECIFIED, (uint8_t *)s->data, sizeof(uint16_t), 1);
+            MEMTXATTRS_UNSPECIFIED, (uint8_t *)s->data, size, 1);
         s->regs[SONIC_CRDA] = s->regs[SONIC_LLFA];
         s->regs[SONIC_ISR] |= SONIC_ISR_PKTRX;
         s->regs[SONIC_RSC] = (s->regs[SONIC_RSC] & 0xff00) | (((s->regs[SONIC_RSC] & 0x00ff) + 1) & 0x00ff);
-- 
2.21.0



  parent reply	other threads:[~2019-11-02 17:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02 17:15 [PATCH 0/3] dp8393x: fix problems detected with Quadra 800 machine Laurent Vivier
2019-11-02 17:15 ` [PATCH 1/3] dp8393x: put the DMA buffer in the state structure Laurent Vivier
2019-11-05 20:29   ` Hervé Poussineau
2019-11-02 17:15 ` Laurent Vivier [this message]
2019-11-02 19:41   ` [PATCH 2/3] dp8393x: fix dp8393x_receive() Philippe Mathieu-Daudé
2019-11-02 19:58     ` Laurent Vivier
2019-11-05 21:06   ` Hervé Poussineau
2019-11-05 21:53     ` Laurent Vivier
2019-11-06  6:13       ` Hervé Poussineau
2019-11-02 17:15 ` [PATCH 3/3] dp8393x: fix receiving buffer exhaustion Laurent Vivier
2019-11-04 10:14   ` Laurent Vivier
2019-11-05 20:45   ` Hervé Poussineau
2019-11-05 20:51     ` Laurent Vivier
2019-11-05 17:48 ` [PATCH 0/3] dp8393x: fix problems detected with Quadra 800 machine Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191102171511.31881-3-laurent@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=hpoussin@reactos.org \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.