Re: [PATCH blktests v2 0/3] Add --config argument for custom config filenames

From: Omar Sandoval <osandov@osandov.com>
To: "André Almeida" <andrealmeid@collabora.com>
Cc: linux-block@vger.kernel.org, osandov@fb.com,
	kernel@collabora.com, krisman@collabora.com
Subject: Re: [PATCH blktests v2 0/3] Add --config argument for custom config filenames
Date: Wed, 13 Nov 2019 12:20:09 -0800	[thread overview]
Message-ID: <20191113202009.GA61960@vader> (raw)
In-Reply-To: <20191030222707.10142-1-andrealmeid@collabora.com>

On Wed, Oct 30, 2019 at 07:27:04PM -0300, André Almeida wrote:
> Instead of just using the default config file, one may also find useful to
> specify which configuration file would like to use without editing the config
> file, like this:
> 
> $ ./check --config=tests_nvme
> ...
> $ ./check -c tests_scsi
> 
> This pull request solves this. This change means to be optional, in the sense
> that the default behavior should not be modified and current setups will not be
> affect by this. To check if this is true, I have done the following test:
> 
> - Print the value of variables $DEVICE_ONLY, $QUICK_RUN, $TIMEOUT,
>   $RUN_ZONED_TESTS, $OUTPUT, $EXCLUDE
>   
> - Run with the following setups:
>     - with a config file in the dir
>     - without a config file in the dir
>     - configuring using command line arguments
> 
> With both original code and with my changes, I validated that the values
> remained the same. Then, I used the argument --config=test_config to check that
> the values of variables are indeed changing.
> 
> This patchset add this feature, update the docs and fix a minor issue with a
> command line argument. Also, I have changed "# shellcheck disable=SC1091" to
> "# shellcheck source=/dev/null", since it seems the proper way to disable this
> check according to shellcheck documentation[1].
> 
> Thanks,
> André
> 
> Changes since v1:
> - Reorder commit, so bug fix comes first
> - Document multiple -c options behavior
> 
> 
> [1] https://github.com/koalaman/shellcheck/wiki/SC1090#exceptions
> 
> This patch is also avaible at GitHub:
> https://github.com/osandov/blktests/pull/56
> 
> André Almeida (3):
>   check: Make "device-only" option a valid option
>   check: Add configuration file option
>   Documentation: Add information about `--config` argument
> 
>  Documentation/running-tests.md |  4 +++-
>  check                          | 30 +++++++++++++++++++++++++-----
>  2 files changed, 28 insertions(+), 6 deletions(-)
> 
> -- 
> 2.23.0
> 

Thanks, applied! I had to rework it a bit so that command line options
would still take precedence over the configuration file, but it should
work now.