Re: [PATCHv2 09/22] crypto: add timeout to crypto_wait_req

From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tero Kristo <t-kristo@ti.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
	linux-omap@vger.kernel.org, ard.biesheuvel@kernel.org,
	Eric Biggers <ebiggers@kernel.org>
Subject: Re: [PATCHv2 09/22] crypto: add timeout to crypto_wait_req
Date: Fri, 15 Nov 2019 13:29:18 +0800	[thread overview]
Message-ID: <20191115052918.htafn2sch3a6aizv@gondor.apana.org.au> (raw)
In-Reply-To: <20191105140111.20285-10-t-kristo@ti.com>

On Tue, Nov 05, 2019 at 04:00:58PM +0200, Tero Kristo wrote:
> Currently crypto_wait_req waits indefinitely for an async crypto request
> to complete. This is bad as it can cause for example the crypto test
> manager to hang without any notification as to why it has happened.
> Instead of waiting indefinitely, add a 1 second timeout to the call,
> and provide a warning print if a timeout happens.
> 
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---
>  include/linux/crypto.h | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

As we discussed before this patch is not acceptable because it
would cause a use-after-free.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt