Re: [RFC PATCH v5 0/7] Speed booting by sorting ORC unwind tables at build time

From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Shile Zhang <shile.zhang@linux.alibaba.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Michal Marek <michal.lkml@markovi.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Andy Lutomirski <luto@amacapital.net>,
	x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [RFC PATCH v5 0/7] Speed booting by sorting ORC unwind tables at build time
Date: Mon, 2 Dec 2019 13:10:29 +0100	[thread overview]
Message-ID: <20191202121029.GA37334@gmail.com> (raw)
In-Reply-To: <20191202103248.GB2827@hirez.programming.kicks-ass.net>

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Thu, Nov 28, 2019 at 07:01:59PM +0800, Shile Zhang wrote:
> > This series refactored the original sortextable tools, add ORC unwind
> > tables sort at build time.
> > 
> > To sort the ORC unwind tables(.orc_unwind & .orc_unwind_ip) can save
> > about 100ms in my test ENV (2C4G VM w/ Xeon 2.5GHz CPU).
> > It costs about 30ms sort by new sorttable tool.
> 
> IIRC from your previous emails the new build-time sort is actually
> shorter than that, so even for single build+run scenarios we win.
> 
> The code looks good to me, so:
> 
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> 
> Who it going to apply this? I suppose we could take it through -tip,
> like we do with all x86 and objtool related bits.

Yeah, will apply it once the merge window slows down a bit.

Thanks,

	Ingo