Re: [PATCH v2 2/2] Btrfs: make tree checker detect checksum items with overlapping ranges

From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Btrfs: make tree checker detect checksum items with overlapping ranges
Date: Tue, 3 Dec 2019 20:11:46 +0100	[thread overview]
Message-ID: <20191203191146.GX2734@twin.jikos.cz> (raw)
In-Reply-To: <20191202110103.20456-1-fdmanana@kernel.org>

On Mon, Dec 02, 2019 at 11:01:03AM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Having checksum items, either on the checksums tree or in a log tree, that
> represent ranges that overlap each other is a sign of a corruption. Such
> case confuses the checksum lookup code and can result in not being able to
> find checksums or find stale checksums.
> 
> So add a check for such case.
> 
> This is motivated by a recent fix for a case where a log tree had checksum
> items covering ranges that overlap each other due to extent cloning, and
> resulted in missing checksums after replaying the log tree. It also helps
> detect past issues such as stale and outdated checksums due to overlapping,
> commit 27b9a8122ff71a ("Btrfs: fix csum tree corruption, duplicate and
> outdated checksums").
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Added to misc-next, thanks.