Re: [PATCH 2/6] arm64: dts: qcom: msm8996: Disable USB2 PHY suspend by core

From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Paolo Pisati <p.pisati@gmail.com>
Cc: Andy Gross <agross@kernel.org>,
	Amit Pundir <amit.pundir@linaro.org>,
	Manu Gautam <mgautam@codeaurora.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: msm8996: Disable USB2 PHY suspend by core
Date: Sat, 7 Dec 2019 12:44:11 -0800	[thread overview]
Message-ID: <20191207204411.GC314059@yoga> (raw)
In-Reply-To: <20191205161505.15295-3-p.pisati@gmail.com>

On Thu 05 Dec 08:15 PST 2019, Paolo Pisati wrote:

> From: Manu Gautam <mgautam@codeaurora.org>
> 
> QUSB2 PHY on msm8996 doesn't work well when autosuspend by
> dwc3 core using USB2PHYCFG register is enabled. One of the
> issue seen is that PHY driver reports PLL lock failure and
> fails phy_init() if dwc3 core has USB2 PHY suspend enabled.
> Fix this by using quirks to disable USB2 PHY LPM/suspend and
> dwc3 core already takes care of explicitly suspending PHY
> during suspend if quirks are specified.
> 
> Signed-off-by: Manu Gautam <mgautam@codeaurora.org>

I haven't yet had the chance to test this, but please add your
Signed-off-by below Manu's and resubmit this patch.

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 87f4d9c..fbb8ce7 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1598,6 +1598,8 @@
>  				interrupts = <0 138 IRQ_TYPE_LEVEL_HIGH>;
>  				phys = <&hsusb_phy2>;
>  				phy-names = "usb2-phy";
> +				snps,dis_u2_susphy_quirk;
> +				snps,dis_enblslpm_quirk;
>  			};
>  		};
>  
> @@ -1628,6 +1630,8 @@
>  				interrupts = <0 131 IRQ_TYPE_LEVEL_HIGH>;
>  				phys = <&hsusb_phy1>, <&ssusb_phy_0>;
>  				phy-names = "usb2-phy", "usb3-phy";
> +				snps,dis_u2_susphy_quirk;
> +				snps,dis_enblslpm_quirk;
>  			};
>  		};
>  
> -- 
> 2.7.4
> 