From: Wei Liu <wl@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "Wei Liu" <liuwe@microsoft.com>, "Wei Liu" <wl@xen.org>,
"Paul Durrant" <paul@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Michael Kelley" <mikelley@microsoft.com>,
"Xen Development List" <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH for-next 2/7] x86: fix up hyperv-tlfs.h
Date: Wed, 11 Dec 2019 11:42:25 +0000 [thread overview]
Message-ID: <20191211114225.pfhczddmqgjyp6mt@debian> (raw)
In-Reply-To: <e48a7077-170b-375e-4a71-02bf3449ad35@suse.com>
On Tue, Dec 10, 2019 at 04:35:41PM +0100, Jan Beulich wrote:
> On 25.10.2019 11:16, Wei Liu wrote:
> > Do the following:
> > 1. include xen/types.h and xen/bitops.h
> > 2. fix up invocations of BIT macro
>
> Is it truly BIT(..., UL) in _all_ cases, and not BIT(..., U) in some?
In Linux BIT is
#define BIT(nr) (UL(1) << nr)
so yes Linux developers did mean UL everywhere.
I haven't checked them one by one per TLFS's definitions though.
Wei.
>
> > Signed-off-by: Wei Liu <liuwe@microsoft.com>
> > ---
> > This can be squashed into previous patch if preferred.
>
> Afaic - yes please.
>
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-11 11:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 9:16 [Xen-devel] [PATCH for-next 0/7] Implement Hyper-V reference TSC based clock source Wei Liu
2019-10-25 9:16 ` [Xen-devel] [PATCH for-next 1/7] x86: import hyperv-tlfs.h from Linux Wei Liu
2019-12-10 15:33 ` Jan Beulich
2019-12-10 15:37 ` Durrant, Paul
2019-12-10 15:43 ` Jan Beulich
2019-12-11 11:14 ` Wei Liu
2019-12-11 11:22 ` Durrant, Paul
2019-12-11 11:28 ` Wei Liu
2019-10-25 9:16 ` [Xen-devel] [PATCH for-next 2/7] x86: fix up hyperv-tlfs.h Wei Liu
2019-12-10 15:35 ` Jan Beulich
2019-12-11 11:42 ` Wei Liu [this message]
2019-10-25 9:16 ` [Xen-devel] [PATCH for-next 3/7] x86/hyperv: extract more information from Hyper-V Wei Liu
2019-12-10 16:10 ` Jan Beulich
2019-10-25 9:16 ` [Xen-devel] [PATCH for-next 4/7] x86: add a comment regarding the location of hypervisor_probe Wei Liu
2019-12-10 16:15 ` Jan Beulich
2019-10-25 9:16 ` [Xen-devel] [PATCH for-next 5/7] x86: use running_on_hypervisor to gate hypervisor_setup Wei Liu
2019-12-10 16:17 ` Jan Beulich
2019-12-11 11:34 ` Wei Liu
2019-10-25 9:16 ` [Xen-devel] [PATCH for-next 6/7] x86/hyperv: provide hyperv_guest variable Wei Liu
2019-12-10 16:39 ` Jan Beulich
2019-10-25 9:16 ` [Xen-devel] [PATCH for-next 7/7] x86: implement Hyper-V clock source Wei Liu
2019-12-10 16:59 ` Jan Beulich
2019-12-18 12:38 ` Wei Liu
2019-12-18 12:51 ` Jan Beulich
2019-12-18 12:56 ` Andrew Cooper
2019-12-18 12:59 ` Wei Liu
2019-12-18 13:28 ` Jan Beulich
2019-12-18 13:18 ` Wei Liu
2019-12-18 13:24 ` Jan Beulich
2019-12-18 13:47 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211114225.pfhczddmqgjyp6mt@debian \
--to=wl@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=liuwe@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=paul@xen.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.