From: Andi Kleen <ak@linux.intel.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Kajol Jain <kjain@linux.ibm.com>,
Jin Yao <yao.jin@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
Anju T Sudhakar <anju@linux.vnet.ibm.com>
Subject: Re: [PATCH] tools/perf/metricgroup: Fix printing event names of metric group with multiple events
Date: Wed, 11 Dec 2019 12:38:02 -0800 [thread overview]
Message-ID: <20191211203802.GB862919@tassilo.jf.intel.com> (raw)
In-Reply-To: <20191211134528.GC15181@kernel.org>
> > But while looking at the patch, I found that, commit f01642e4912b
> > has (again) screwed up logic for metric with overlapping events.
>
> Is someone looking into this?
Looks like we really need some proper regression tests for this.
-Andi
next prev parent reply other threads:[~2019-12-11 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 8:40 [PATCH] tools/perf/metricgroup: Fix printing event names of metric group with multiple events Kajol Jain
2019-12-04 6:55 ` Ravi Bangoria
2019-12-11 13:45 ` Arnaldo Carvalho de Melo
2019-12-11 20:38 ` Andi Kleen [this message]
2019-12-12 5:54 ` kajoljain
2019-12-17 11:31 ` [tip: perf/urgent] perf metricgroup: " tip-bot2 for Kajol Jain
-- strict thread matches above, loose matches on Subject: below --
2019-11-18 10:37 [PATCH] tools/perf/metricgroup: " Kajol Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211203802.GB862919@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anju@linux.vnet.ibm.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.