From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915/tgl: Drop Wa#1178
Date: Thu, 12 Dec 2019 15:52:11 -0800 [thread overview]
Message-ID: <20191212235211.zv5kbjuol536hlz7@ldmartin-desk1> (raw)
In-Reply-To: <20191212223735.666014-3-matthew.d.roper@intel.com>
On Thu, Dec 12, 2019 at 02:37:34PM -0800, Matt Roper wrote:
>The TGL workaround database no longer shows Wa #1178 (or anything
>similar under different workaround names/numbers) so we should be able
>to drop it. In fact Swati just discovered that applying this workaround
>is the root cause of some power well enable failures we've been seeing
>in CI (gitlab issue 498).
>
>Once we stop applying this WA, TGL no longer utilizes any of the special
>handling provided by icl_combo_phy_aux_power_well_ops so we can just
>drop back to using the standard hsw-style power well ops instead.
>
>Closes: https://gitlab.freedesktop.org/drm/intel/issues/498
>Fixes: deea06b47574 ("drm/i915/tgl: apply Display WA #1178 to fix type C dongles")
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: Swati Sharma <swati2.sharma@intel.com>
>Cc: Imre Deak <imre.deak@intel.com>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
>---
> drivers/gpu/drm/i915/display/intel_display_power.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
>index cf34427cc840..52f2332e0ab8 100644
>--- a/drivers/gpu/drm/i915/display/intel_display_power.c
>+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
>@@ -3977,7 +3977,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = {
> {
> .name = "AUX A",
> .domains = TGL_AUX_A_IO_POWER_DOMAINS,
>- .ops = &icl_combo_phy_aux_power_well_ops,
>+ .ops = &hsw_power_well_ops,
> .id = DISP_PW_ID_NONE,
> {
> .hsw.regs = &icl_aux_power_well_regs,
>@@ -3987,7 +3987,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = {
> {
> .name = "AUX B",
> .domains = TGL_AUX_B_IO_POWER_DOMAINS,
>- .ops = &icl_combo_phy_aux_power_well_ops,
>+ .ops = &hsw_power_well_ops,
> .id = DISP_PW_ID_NONE,
> {
> .hsw.regs = &icl_aux_power_well_regs,
>@@ -3997,7 +3997,7 @@ static const struct i915_power_well_desc tgl_power_wells[] = {
> {
> .name = "AUX C",
> .domains = TGL_AUX_C_IO_POWER_DOMAINS,
>- .ops = &icl_combo_phy_aux_power_well_ops,
>+ .ops = &hsw_power_well_ops,
> .id = DISP_PW_ID_NONE,
> {
> .hsw.regs = &icl_aux_power_well_regs,
>--
>2.23.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-12 23:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 22:37 [Intel-gfx] [PATCH 0/3] AUX power well fixes Matt Roper
2019-12-12 22:37 ` [Intel-gfx] [PATCH 1/3] drm/i915/ehl: Define EHL powerwells independently of ICL Matt Roper
2019-12-12 22:37 ` [Intel-gfx] [PATCH 2/3] drm/i915/tgl: Drop Wa#1178 Matt Roper
2019-12-12 23:52 ` Lucas De Marchi [this message]
2019-12-12 22:37 ` [Intel-gfx] [PATCH 3/3] drm/i915/icl: Cleanup combo PHY aux power well handlers Matt Roper
2019-12-12 23:04 ` Lucas De Marchi
2019-12-12 23:51 ` [Intel-gfx] [PATCH v2 " Matt Roper
2019-12-12 23:56 ` Lucas De Marchi
2019-12-13 0:03 ` Matt Roper
2019-12-19 0:43 ` [Intel-gfx] [PATCH " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212235211.zv5kbjuol536hlz7@ldmartin-desk1 \
--to=lucas.demarchi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.