From: Vinod Koul <vkoul@kernel.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
MSM <linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Can Guo <cang@codeaurora.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] phy: qcom-qmp: Increase the phy init timeout
Date: Thu, 19 Dec 2019 21:10:09 +0530 [thread overview]
Message-ID: <20191219154009.GX2536@vkoul-mobl> (raw)
In-Reply-To: <CAOCk7Npwkx0hJ6hom7yDbN_n-a=sybVi7A=unc4d3UPJysPr+Q@mail.gmail.com>
On 19-12-19, 08:29, Jeffrey Hugo wrote:
> On Thu, Dec 19, 2019 at 8:04 AM Vinod Koul <vkoul@kernel.org> wrote:
> >
> > If we do full reset of the phy, it seems to take a couple of ms to come
> > up on my system so increase the timeout to 10ms.
> >
> > This was found by full reset addition by commit 870b1279c7a0
> > ("scsi: ufs-qcom: Add reset control support for host controller") and
> > fixes the regression to platforms by this commit.
> >
> > Suggested-by: Can Guo <cang@codeaurora.org>
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
> Tested-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>
> Tested on the Lenovo Miix 630 laptop (a msm8998 based system). This
> addresses the regression.
Thanks Jeff for quick test and reviews! Appreciate it.
> > ---
> > drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> > index 091e20303a14..c2e800a3825a 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> > @@ -66,7 +66,7 @@
> > /* QPHY_V3_PCS_MISC_CLAMP_ENABLE register bits */
> > #define CLAMP_EN BIT(0) /* enables i/o clamp_n */
> >
> > -#define PHY_INIT_COMPLETE_TIMEOUT 1000
> > +#define PHY_INIT_COMPLETE_TIMEOUT 100000
> > #define POWER_DOWN_DELAY_US_MIN 10
> > #define POWER_DOWN_DELAY_US_MAX 11
> >
> > --
> > 2.23.0
> >
--
~Vinod
next prev parent reply other threads:[~2019-12-19 15:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 15:04 [PATCH 0/4] phy: qcom-qmp: Fixes and updates for sm8150 Vinod Koul
2019-12-19 15:04 ` [PATCH 1/4] phy: qcom-qmp: Increase the phy init timeout Vinod Koul
2019-12-19 15:29 ` Jeffrey Hugo
2019-12-19 15:40 ` Vinod Koul [this message]
2019-12-20 2:08 ` Bjorn Andersson
2019-12-20 4:21 ` Vinod Koul
2019-12-19 15:04 ` [PATCH 2/4] phy: qcom-qmp: Use register defines Vinod Koul
2019-12-19 15:30 ` Jeffrey Hugo
2019-12-20 0:44 ` cang
2019-12-20 4:22 ` Vinod Koul
2019-12-19 15:04 ` [PATCH 3/4] phy: qcom-qmp: Add optional SW reset Vinod Koul
2019-12-19 15:31 ` Jeffrey Hugo
2019-12-20 0:22 ` cang
2019-12-20 0:49 ` cang
2019-12-20 4:24 ` Vinod Koul
2019-12-20 6:00 ` Can Guo
2019-12-20 7:10 ` Vinod Koul
2019-12-20 7:41 ` Can Guo
2019-12-20 7:53 ` Vinod Koul
2019-12-23 9:00 ` Manu Gautam
2019-12-23 9:02 ` Manu Gautam
2019-12-19 15:04 ` [PATCH 4/4] phy: qcom-qmp: remove duplicate powerdown write Vinod Koul
2019-12-19 15:31 ` Jeffrey Hugo
2019-12-20 1:30 ` Can Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219154009.GX2536@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.