From: Jeff King <peff@peff.net>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Luis Marsano <luis.marsano@gmail.com>,
Ted Zlatanov <tzz@lifelogs.com>
Subject: Re: [RESEND PATCH 0/2] contrib/credential/netrc: Makefile + script cleanup
Date: Fri, 20 Dec 2019 15:59:47 -0500 [thread overview]
Message-ID: <20191220205947.GA2752079@coredump.intra.peff.net> (raw)
In-Reply-To: <cover.1576867467.git.liu.denton@gmail.com>
On Fri, Dec 20, 2019 at 10:44:59AM -0800, Denton Liu wrote:
> I recently switched my workflow to use this credential helper and I
> noticed a couple of problems:
>
> 1. The interpreter path was hardcoded to #!/usr/bin/perl
>
> 2. The script refuses to run outside of a Git repository
>
> This patch series should fix these problems.
Since this is just a re-send, I'll re-send my:
Reviewed-by: Jeff King <peff@peff.net>
:)
-Peff
prev parent reply other threads:[~2019-12-20 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 21:32 [PATCH 0/2] contrib/credential/netrc: Makefile + script cleanup Denton Liu
2019-12-16 21:32 ` [PATCH 1/2] contrib/credential/netrc: make PERL_PATH configurable Denton Liu
2019-12-16 21:32 ` [PATCH 2/2] contrib/credential/netrc: work outside a repo Denton Liu
2019-12-17 2:48 ` [PATCH 0/2] contrib/credential/netrc: Makefile + script cleanup Jeff King
2019-12-17 6:17 ` Denton Liu
2019-12-20 18:44 ` [RESEND PATCH " Denton Liu
2019-12-20 18:45 ` [RESEND PATCH 1/2] contrib/credential/netrc: make PERL_PATH configurable Denton Liu
2019-12-20 18:45 ` [RESEND PATCH 2/2] contrib/credential/netrc: work outside a repo Denton Liu
2019-12-20 20:59 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220205947.GA2752079@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=luis.marsano@gmail.com \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.