From: Vinod Koul <vkoul@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
ryan@edited.us, aserbinski@gmail.com, dmaengine@vger.kernel.org
Subject: Re: [PATCH] k3dma: Avoid null pointer traversal
Date: Mon, 23 Dec 2019 13:21:43 +0530 [thread overview]
Message-ID: <20191223075143.GC2536@vkoul-mobl> (raw)
In-Reply-To: <20191218190906.6641-1-john.stultz@linaro.org>
On 18-12-19, 19:09, John Stultz wrote:
> In some cases we seem to submit two transactions in a row, which
> causes us to lose track of the first. If we then cancel the
> request, we may still get an interrupt, which traverses a null
> ds_run value.
>
> So try to avoid starting a new transaction if the ds_run value
> is set.
>
> While this patch avoids the null pointer crash, I've had some
> reports of the k3dma driver still getting confused, which
> suggests the ds_run/ds_done value handling still isn't quite
> right. However, I've not run into an issue recently with it
> so I think this patch is worth pushing upstream to avoid the
> crash.
Applied after adding dmaengine tag, thanks
--
~Vinod
prev parent reply other threads:[~2019-12-23 7:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 19:09 [PATCH] k3dma: Avoid null pointer traversal John Stultz
2019-12-23 7:51 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191223075143.GC2536@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=aserbinski@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ryan@edited.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.