From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Brian Foster <bfoster@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: rework insert range into an atomic operation
Date: Tue, 24 Dec 2019 03:28:45 -0800 [thread overview]
Message-ID: <20191224112845.GC24663@infradead.org> (raw)
In-Reply-To: <20191220201717.GQ7489@magnolia>
On Fri, Dec 20, 2019 at 12:17:17PM -0800, Darrick J. Wong wrote:
> I think directio completions might suffer from the same class of problem
> though, since we allow concurrent dio writes and dio doesn't do any of
> the ioend batching that we do with buffered write ioends.
OTOH direct I/O completions are per-I/O, and not per-extent like
buffered I/O completions. Moreover for the case where we don't update
i_size and don't need a separate log force (overwrites without O_SYNC
or using fua) we could actually avoid the workqueue entirely with just
a little work.
> It might also be nice to find a way to unify the ioend paths since they
> both do "convert unwritten and do cow remapping" on the entire range,
> and diverge only once that's done.
They were common a while ago and it was a complete mess. That is why
I split them.
next prev parent reply other threads:[~2019-12-24 11:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 17:12 [PATCH 0/3] xfs: hold ilock across insert and collapse range Brian Foster
2019-12-13 17:12 ` [PATCH 1/3] xfs: open code insert range extent split helper Brian Foster
2019-12-17 17:02 ` Allison Collins
2019-12-17 22:21 ` Darrick J. Wong
2019-12-18 2:16 ` Darrick J. Wong
2019-12-24 11:18 ` Christoph Hellwig
2019-12-13 17:12 ` [PATCH 2/3] xfs: rework insert range into an atomic operation Brian Foster
2019-12-17 17:04 ` Allison Collins
2019-12-18 2:37 ` Darrick J. Wong
2019-12-18 12:10 ` Brian Foster
2019-12-18 21:15 ` Darrick J. Wong
2019-12-19 11:55 ` Brian Foster
2019-12-20 20:17 ` Darrick J. Wong
2019-12-23 12:12 ` Brian Foster
2019-12-24 11:28 ` Christoph Hellwig [this message]
2019-12-24 16:45 ` Darrick J. Wong
2019-12-24 11:26 ` Christoph Hellwig
2019-12-13 17:12 ` [PATCH 3/3] xfs: rework collapse " Brian Foster
2019-12-18 2:39 ` Darrick J. Wong
2019-12-18 12:11 ` Brian Foster
2019-12-18 21:19 ` Darrick J. Wong
2019-12-19 11:56 ` Brian Foster
2019-12-24 11:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224112845.GC24663@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.