Re: [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz()

From: Gal Pressman <galpress@amazon.com>
To: Jason Gunthorpe <jgg@nvidia.com>, <linux-rdma@vger.kernel.org>
Cc: Shiraz Saleem <shiraz.saleem@intel.com>
Subject: Re: [PATCH] RDMA/umem: Fix signature of stub ib_umem_find_best_pgsz()
Date: Wed, 26 Aug 2020 09:15:27 +0300	[thread overview]
Message-ID: <201bad07-2efc-9712-17d1-86c75c53e187@amazon.com> (raw)
In-Reply-To: <0-v1-982a13cc5c6d+501ae-fix_best_pgsz_stub_jgg@nvidia.com>

On 25/08/2020 21:17, Jason Gunthorpe wrote:
> The original function returns unsigned long and 0 on failure.
> 
> Fixes: 4a35339958f1 ("RDMA/umem: Add API to find best driver supported page size in an MR")
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>  include/rdma/ib_umem.h | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/include/rdma/ib_umem.h b/include/rdma/ib_umem.h
> index 71f573a418bf06..07a764eb692eed 100644
> --- a/include/rdma/ib_umem.h
> +++ b/include/rdma/ib_umem.h
> @@ -68,10 +68,11 @@ static inline int ib_umem_copy_from(void *dst, struct ib_umem *umem, size_t offs
>  		      		    size_t length) {
>  	return -EINVAL;
>  }
> -static inline int ib_umem_find_best_pgsz(struct ib_umem *umem,
> -					 unsigned long pgsz_bitmap,
> -					 unsigned long virt) {
> -	return -EINVAL;
> +static inline unsigned long ib_umem_find_best_pgsz(struct ib_umem *umem,
> +						   unsigned long pgsz_bitmap,
> +						   unsigned long virt)
> +{
> +	return 0;
>  }
>  
>  #endif /* CONFIG_INFINIBAND_USER_MEM */
> 

Reviewed-by: Gal Pressman <galpress@amazon.com>