Re: [PATCH v2 0/5] xfstests: verify ciphertext of IV_INO_LBLK_64 encryption policies

From: Eryu Guan <eguan@linux.alibaba.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: fstests@vger.kernel.org, Eryu Guan <guaneryu@gmail.com>,
	linux-fscrypt@vger.kernel.org,
	Satya Tangirala <satyat@google.com>
Subject: Re: [PATCH v2 0/5] xfstests: verify ciphertext of IV_INO_LBLK_64 encryption policies
Date: Mon, 6 Jan 2020 10:55:09 +0800	[thread overview]
Message-ID: <20200106025509.GF41863@e18g06458.et15sqa> (raw)
In-Reply-To: <20200103164626.GA19521@gmail.com>

On Fri, Jan 03, 2020 at 08:46:26AM -0800, Eric Biggers wrote:
> On Mon, Dec 09, 2019 at 10:18:27AM -0800, Eric Biggers wrote:
> > On Mon, Dec 02, 2019 at 03:01:50PM -0800, Eric Biggers wrote:
> > > Hello,
> > > 
> > > This series adds an xfstest which tests that the encryption for
> > > IV_INO_LBLK_64 encryption policies is being done correctly.
> > > 
> > > IV_INO_LBLK_64 is a new fscrypt policy flag which modifies the
> > > encryption to be optimized for inline encryption hardware compliant with
> > > the UFS v2.1 standard or the upcoming version of the eMMC standard.  For
> > > more information, see the kernel patchset:
> > > https://lore.kernel.org/linux-fscrypt/20191024215438.138489-1-ebiggers@kernel.org/T/#u
> > > 
> > > The kernel patches have been merged into mainline and will be in v5.5.
> > > 
> > > In addition to the latest kernel, to run on ext4 this test also needs a
> > > version of e2fsprogs built from the master branch, in order to get
> > > support for formatting the filesystem with '-O stable_inodes'.
> > > 
> > > As usual, the test will skip itself if the prerequisites aren't met.
> > > 
> > > No real changes since v1; just rebased onto the latest xfstests master
> > > branch and updated the cover letter.
> > > 
> > > Eric Biggers (5):
> > >   fscrypt-crypt-util: create key_and_iv_params structure
> > >   fscrypt-crypt-util: add HKDF context constants
> > >   common/encrypt: create named variables for UAPI constants
> > >   common/encrypt: support verifying ciphertext of IV_INO_LBLK_64
> > >     policies
> > >   generic: verify ciphertext of IV_INO_LBLK_64 encryption policies
> > > 
> > >  common/encrypt           | 126 +++++++++++++++++++++++++-------
> > >  src/fscrypt-crypt-util.c | 151 ++++++++++++++++++++++++++++-----------
> > >  tests/generic/805        |  43 +++++++++++
> > >  tests/generic/805.out    |   6 ++
> > >  tests/generic/group      |   1 +
> > >  5 files changed, 259 insertions(+), 68 deletions(-)
> > >  create mode 100644 tests/generic/805
> > >  create mode 100644 tests/generic/805.out
> > > 
> > 
> > Ping.  Does anyone want to take a look at this?  Satya?
> > 
> 
> Eryu, can you review and consider applying this series?  It doesn't look like
> anyone else is going to formally review it.

I've reviewed & applied this patchset in my local tree, will push them
out soon. So sorry for the delay!

Thanks,
Eryu