All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: s.riedmueller@phytec.de, s.christ@phytec.de,
	chf.fritz@googlemail.com, robh+dt@kernel.org, linux-imx@nxp.com,
	kernel@pengutronix.de, c.hemp@phytec.de, shawnguo@kernel.org,
	festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
Date: Wed, 8 Jan 2020 10:34:07 +0000	[thread overview]
Message-ID: <20200108103407.GL25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200108101057.29599-1-m.felsch@pengutronix.de>

On Wed, Jan 08, 2020 at 11:10:55AM +0100, Marco Felsch wrote:
> The current set minimum voltage of 730000mV seems to be wrong. I don't

mV = milli-volt, /1000th of a volt. So you just said 730V.
µV or uV = micro-volt, which I think is what you mean here.

> know the document which specifies that but the imx6qdl datasheets says
> that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed,
> lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp).
> 
> Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> v2:
> - use ldo bypassed values
> - adapt commit message
> 
>  arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> index 6486df3e2942..f23eef1e54e0 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -107,14 +107,14 @@
>  		regulators {
>  			vdd_arm: buck1 {
>  				regulator-name = "vdd_arm";
> -				regulator-min-microvolt = <730000>;
> +				regulator-min-microvolt = <925000>;
>  				regulator-max-microvolt = <1380000>;
>  				regulator-always-on;
>  			};
>  
>  			vdd_soc: buck2 {
>  				regulator-name = "vdd_soc";
> -				regulator-min-microvolt = <730000>;
> +				regulator-min-microvolt = <1150000>;
>  				regulator-max-microvolt = <1380000>;
>  				regulator-always-on;
>  			};
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-01-08 10:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 10:10 [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
2020-01-08 10:10 ` [PATCH v2 2/3] ARM: dts: imx6: phycore-som: fix emmc supply Marco Felsch
2020-01-08 10:10 ` [PATCH v2 3/3] ARM: dts: imx6: phycore-som: add pmic onkey device Marco Felsch
2020-01-08 10:34 ` Russell King - ARM Linux admin [this message]
2020-01-08 10:42   ` [PATCH v2 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200108103407.GL25745@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=c.hemp@phytec.de \
    --cc=chf.fritz@googlemail.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=m.felsch@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=s.christ@phytec.de \
    --cc=s.riedmueller@phytec.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.