From: Christoph Hellwig <hch@infradead.org>
To: Nikolai Merinov <n.merinov@inango-systems.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>, Jens Axboe <axboe@kernel.dk>,
linux-efi@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] partitions/efi: Fix partition name parsing in GUID partition entry
Date: Wed, 8 Jan 2020 05:39:26 -0800 [thread overview]
Message-ID: <20200108133926.GC4455@infradead.org> (raw)
In-Reply-To: <20191224092119.4581-1-n.merinov@inango-systems.com>
> index db2fef7dfc47..51287a8a3bea 100644
> --- a/block/partitions/efi.c
> +++ b/block/partitions/efi.c
> @@ -715,7 +715,7 @@ int efi_partition(struct parsed_partitions *state)
> ARRAY_SIZE(ptes[i].partition_name));
> info->volname[label_max] = 0;
> while (label_count < label_max) {
> - u8 c = ptes[i].partition_name[label_count] & 0xff;
> + u8 c = le16_to_cpu(ptes[i].partition_name[label_count]) & 0xff;
> if (c && !isprint(c))
> c = '!';
>
This adds an overly long line. Please add a an efi_char_from_cpu or
similarly named helper to encapsulate this logic.
Otherwise the change looks good.
next prev parent reply other threads:[~2020-01-08 13:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 16:21 [PATCH] partitions/efi: Fix partition name parsing in GUID partition entry Nikolai Merinov
2018-11-25 21:16 ` kbuild test robot
2018-11-25 21:16 ` kbuild test robot
2019-12-24 9:21 ` [PATCH v2] " Nikolai Merinov
2019-12-24 9:51 ` Ard Biesheuvel
2020-01-08 13:39 ` Christoph Hellwig [this message]
2020-01-13 10:27 ` [PATCH v3] " Nikolai Merinov
2020-02-18 13:34 ` Nikolai Merinov
2020-02-18 18:53 ` Christoph Hellwig
2020-02-24 11:38 ` Nikolai Merinov
2020-02-24 17:08 ` hch
2020-03-06 8:43 ` Nikolai Merinov
2020-03-06 9:25 ` Ard Biesheuvel
2020-03-06 10:14 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200108133926.GC4455@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n.merinov@inango-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.