All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
	qemu-block@nongnu.org, oleksandr@redhat.com,
	Julia Suvorova <jusual@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Aarushi Mehta <mehta.aaru20@gmail.com>,
	Stefano Garzarella <sgarzare@redhat.com>
Subject: [PATCH v4 05/15] stubs: add stubs for io_uring interface
Date: Tue, 14 Jan 2020 10:59:11 +0000	[thread overview]
Message-ID: <20200114105921.131880-6-stefanha@redhat.com> (raw)
In-Reply-To: <20200114105921.131880-1-stefanha@redhat.com>

From: Aarushi Mehta <mehta.aaru20@gmail.com>

Follow linux-aio.o and stub out the block/io_uring.o APIs that will be
missing when a binary is linked with obj-util-y but without
block-util-y (e.g. vhost-user-gpu).

For example, the stubs are necessary so that a binary using util/async.o
from obj-util-y for qemu_bh_new() links successfully.  In this case
block/io_uring.o from block-util-y isn't needed and we can avoid
dragging in the block layer by linking the stubs instead.  The stub
functions never get called.

Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
Acked-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 MAINTAINERS         |  1 +
 stubs/Makefile.objs |  1 +
 stubs/io_uring.c    | 32 ++++++++++++++++++++++++++++++++
 3 files changed, 34 insertions(+)
 create mode 100644 stubs/io_uring.c

diff --git a/MAINTAINERS b/MAINTAINERS
index dc9da76b84..ab15b76912 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2613,6 +2613,7 @@ M: Stefan Hajnoczi <stefanha@redhat.com>
 L: qemu-block@nongnu.org
 S: Maintained
 F: block/io_uring.c
+F: stubs/io_uring.c
 
 qcow2
 M: Kevin Wolf <kwolf@redhat.com>
diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs
index 8b0ff25508..7afbe5fb61 100644
--- a/stubs/Makefile.objs
+++ b/stubs/Makefile.objs
@@ -13,6 +13,7 @@ stub-obj-y += iothread.o
 stub-obj-y += iothread-lock.o
 stub-obj-y += is-daemonized.o
 stub-obj-$(CONFIG_LINUX_AIO) += linux-aio.o
+stub-obj-$(CONFIG_LINUX_IO_URING) += io_uring.o
 stub-obj-y += machine-init-done.o
 stub-obj-y += migr-blocker.o
 stub-obj-y += change-state-handler.o
diff --git a/stubs/io_uring.c b/stubs/io_uring.c
new file mode 100644
index 0000000000..622d1e4648
--- /dev/null
+++ b/stubs/io_uring.c
@@ -0,0 +1,32 @@
+/*
+ * Linux io_uring support.
+ *
+ * Copyright (C) 2009 IBM, Corp.
+ * Copyright (C) 2009 Red Hat, Inc.
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+#include "qemu/osdep.h"
+#include "block/aio.h"
+#include "block/raw-aio.h"
+
+void luring_detach_aio_context(LuringState *s, AioContext *old_context)
+{
+    abort();
+}
+
+void luring_attach_aio_context(LuringState *s, AioContext *new_context)
+{
+    abort();
+}
+
+LuringState *luring_init(Error **errp)
+{
+    abort();
+}
+
+void luring_cleanup(LuringState *s)
+{
+    abort();
+}
-- 
2.24.1



  parent reply	other threads:[~2020-01-14 11:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 10:59 [PATCH v4 00/15] io_uring: add Linux io_uring AIO engine Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 01/15] configure: permit use of io_uring Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 02/15] qapi/block-core: add option for io_uring Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 03/15] block/block: add BDRV flag " Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 04/15] block/io_uring: implements interfaces " Stefan Hajnoczi
2020-01-14 10:59 ` Stefan Hajnoczi [this message]
2020-01-14 10:59 ` [PATCH v4 06/15] util/async: add aio " Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 07/15] blockdev: adds bdrv_parse_aio to use io_uring Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 08/15] block/file-posix.c: extend " Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 09/15] block: add trace events for io_uring Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 10/15] block/io_uring: adds userspace completion polling Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 11/15] qemu-io: adds option to use aio engine Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 12/15] qemu-img: adds option to use aio engine for benchmarking Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 13/15] qemu-nbd: adds option for aio engines Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 14/15] tests/qemu-iotests: enable testing with aio options Stefan Hajnoczi
2020-01-14 10:59 ` [PATCH v4 15/15] tests/qemu-iotests: use AIOMODE with various tests Stefan Hajnoczi
2020-01-20 10:35 ` [PATCH v4 00/15] io_uring: add Linux io_uring AIO engine Stefan Hajnoczi
2020-01-21 11:35   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200114105921.131880-6-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=fam@euphon.net \
    --cc=jusual@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mehta.aaru20@gmail.com \
    --cc=mreitz@redhat.com \
    --cc=oleksandr@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.