All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v3] iotests: Add more "skip_if_unsupported" statements to the python tests
Date: Tue, 14 Jan 2020 15:34:24 +0100	[thread overview]
Message-ID: <20200114143424.GC8159@linux.fritz.box> (raw)
In-Reply-To: <20200114140203.24326-1-thuth@redhat.com>

Am 14.01.2020 um 15:02 hat Thomas Huth geschrieben:
> The python code already contains a possibility to skip tests if the
> corresponding driver is not available in the qemu binary - use it
> in more spots to avoid that the tests are failing if the driver has
> been disabled.
> 
> While we're at it, we can now also remove some of the old checks that
> were using iotests.supports_quorum() - and which were apparently not
> working as expected since the tests aborted instead of being skipped
> when "quorum" was missing in the QEMU binary.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  v3:
>  - Remove the old iotests.supports_quorum()-based tests
>  - Check for "throttle" in 245, too

Thanks, applied to the block branch.

Kevin



      reply	other threads:[~2020-01-14 14:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 14:02 [PATCH v3] iotests: Add more "skip_if_unsupported" statements to the python tests Thomas Huth
2020-01-14 14:34 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200114143424.GC8159@linux.fritz.box \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.