From: Petr Mladek <pmladek@suse.com>
To: Qian Cai <cai@lca.pw>
Cc: Michal Hocko <mhocko@kernel.org>,
David Hildenbrand <david@redhat.com>,
akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com,
rostedt@goodmis.org, peterz@infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] mm/hotplug: silence a lockdep splat with printk()
Date: Wed, 15 Jan 2020 18:02:35 +0100 [thread overview]
Message-ID: <20200115170235.ph7lrojaktmfikm2@pathway.suse.cz> (raw)
In-Reply-To: <D6F57A74-7608-43BE-B909-4350DE95B68C@lca.pw>
On Wed 2020-01-15 06:49:03, Qian Cai wrote:
>
>
> > On Jan 15, 2020, at 4:52 AM, Petr Mladek <pmladek@suse.com> wrote:
> >
> > I could understand that Michal is against hack in -mm code that
> > would just hide a false positive warning.
>
> Well, I don’t have any confidence to say everything this patch is
> trying to fix is false positives.
You look at this from a wrong angle. AFAIK, all lockdep reports pasted
in the below mentioned thread were false positives. Now, this patch
complicates an already complicated -mm code to hide the warning
and fix theoretical problems.
I suggest to disable lockdep around the safe allocation in the console
initialization code. Then we will see if there are other locations
that trigger this lockdep warning. It is trivial and will not
complicate the code because of false positives.
> I have been spent the last a few months to research this, so
> I don’t feel like to do this again.
>
> https://lore.kernel.org/linux-mm/1570633715.5937.10.camel@lca.pw/
Have you tried to disable lockdep around the problematic allocation?
Have you seen other lockdep reports caused by exactly this printk()
in the allocator code?
My big problem with this patch is that the commit message does not
contain any lockdep report. It will complicate removing the hack
when it is not longer needed. Nobody will know what was the exact
problem and if it is safe to get removed. I believe that printk()
will offload console handling rather sooner than later and this
extra logic will not be necessary.
Best Regards,
Petr
next prev parent reply other threads:[~2020-01-15 17:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 20:11 [PATCH -next] mm/hotplug: silence a lockdep splat with printk() Qian Cai
2020-01-14 20:20 ` David Hildenbrand
2020-01-14 21:02 ` Michal Hocko
2020-01-14 21:40 ` Qian Cai
2020-01-14 23:53 ` Andrew Morton
2020-01-15 1:02 ` Qian Cai
2020-01-15 1:19 ` Andrew Morton
2020-01-15 1:38 ` Qian Cai
2020-01-15 8:37 ` Michal Hocko
2020-01-15 9:52 ` Petr Mladek
2020-01-15 11:49 ` Qian Cai
2020-01-15 17:02 ` Petr Mladek [this message]
2020-01-15 17:16 ` Qian Cai
2020-01-16 14:29 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115170235.ph7lrojaktmfikm2@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.