From: Mark Brown <broonie@kernel.org>
To: Ben Whitten <ben.whitten@gmail.com>
Cc: linux-kernel@vger.kernel.org, afaerber@suse.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2 2/2] regmap: stop splitting writes to non incrementing registers
Date: Mon, 20 Jan 2020 18:09:45 +0000 [thread overview]
Message-ID: <20200120180945.GL6852@sirena.org.uk> (raw)
In-Reply-To: <20200118205625.14532-2-ben.whitten@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 621 bytes --]
On Sat, Jan 18, 2020 at 08:56:25PM +0000, Ben Whitten wrote:
> When writing to non incrementing registers we should not split
> the writes in any way, writing in one transaction.
That's not an obviously true statement. If the user is intentionally
writing to a non-incrementing register and intends to stuff a block of
data into that one register via regmap_noinc_write() then sure but if
we've come in through a path that isn't specifically for the device or
is using one of the generic APIs then it's going to expect that the
framework will hide the unfortunate choices of the chip implementors and
split the I/O up.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-01-20 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 20:56 [PATCH v2 1/2] regmap: fix writes to non incrementing registers Ben Whitten
2020-01-18 20:56 ` [PATCH v2 2/2] regmap: stop splitting " Ben Whitten
2020-01-20 18:09 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120180945.GL6852@sirena.org.uk \
--to=broonie@kernel.org \
--cc=afaerber@suse.de \
--cc=ben.whitten@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.