From: Greg Kurz <groug@kaod.org>
To: Ganesh Goudar <ganeshgr@linux.ibm.com>
Cc: Aravinda Prasad <arawinda.p@gmail.com>,
aik@ozlabs.ru, qemu-devel@nongnu.org, paulus@ozlabs.org,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH v20 7/7] ppc: spapr: Activate the FWNMI functionality
Date: Wed, 22 Jan 2020 12:33:27 +0100 [thread overview]
Message-ID: <20200122123327.469dc7df@bahia.lan> (raw)
In-Reply-To: <20200117093855.19074-8-ganeshgr@linux.ibm.com>
On Fri, 17 Jan 2020 15:08:55 +0530
Ganesh Goudar <ganeshgr@linux.ibm.com> wrote:
> From: Aravinda Prasad <arawinda.p@gmail.com>
>
> This patch sets the default value of SPAPR_CAP_FWNMI_MCE
> to SPAPR_CAP_ON for machine type 4.2.
>
Now that 4.2 has been released, we want this for 5.0...
> Signed-off-by: Aravinda Prasad <arawinda.p@gmail.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@linux.ibm.com>
> ---
> hw/ppc/spapr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index c8bc2fa9f3..a81c18b6b6 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -4454,7 +4454,7 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data)
> smc->default_caps.caps[SPAPR_CAP_NESTED_KVM_HV] = SPAPR_CAP_OFF;
> smc->default_caps.caps[SPAPR_CAP_LARGE_DECREMENTER] = SPAPR_CAP_ON;
> smc->default_caps.caps[SPAPR_CAP_CCF_ASSIST] = SPAPR_CAP_OFF;
> - smc->default_caps.caps[SPAPR_CAP_FWNMI_MCE] = SPAPR_CAP_OFF;
> + smc->default_caps.caps[SPAPR_CAP_FWNMI_MCE] = SPAPR_CAP_ON;
> spapr_caps_add_properties(smc, &error_abort);
> smc->irq = &spapr_irq_dual;
> smc->dr_phb_enabled = true;
> @@ -4544,6 +4544,7 @@ static void spapr_machine_4_1_class_options(MachineClass *mc)
> smc->smp_threads_vsmt = false;
> compat_props_add(mc->compat_props, hw_compat_4_1, hw_compat_4_1_len);
> compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat));
> + smc->default_caps.caps[SPAPR_CAP_FWNMI_MCE] = SPAPR_CAP_OFF;
... this should go to spapr_machine_4_2_class_options().
> }
>
> DEFINE_SPAPR_MACHINE(4_1, "4.1", false);
prev parent reply other threads:[~2020-01-22 11:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 9:38 [PATCH v20 0/7]target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests Ganesh Goudar
2020-01-17 9:38 ` [PATCH v20 1/7] Wrapper function to wait on condition for the main loop mutex Ganesh Goudar
2020-01-17 9:38 ` [PATCH v20 2/7] ppc: spapr: Introduce FWNMI capability Ganesh Goudar
2020-01-20 0:40 ` David Gibson
2020-01-17 9:38 ` [PATCH v20 3/7] target/ppc: Handle NMI guest exit Ganesh Goudar
2020-01-17 9:38 ` [PATCH v20 4/7] target/ppc: Build rtas error log upon an MCE Ganesh Goudar
2020-01-17 9:38 ` [PATCH v20 5/7] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls Ganesh Goudar
2020-01-20 0:46 ` [PATCH v20 5/7] ppc: spapr: Handle "ibm,nmi-register" and "ibm,nmi-interlock" " David Gibson
2020-01-20 17:18 ` Ganesh
2020-01-17 9:38 ` [PATCH v20 6/7] migration: Include migration support for machine check handling Ganesh Goudar
2020-01-20 0:48 ` David Gibson
2020-01-20 17:31 ` Ganesh
2020-01-17 9:38 ` [PATCH v20 7/7] ppc: spapr: Activate the FWNMI functionality Ganesh Goudar
2020-01-22 11:33 ` Greg Kurz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122123327.469dc7df@bahia.lan \
--to=groug@kaod.org \
--cc=aik@ozlabs.ru \
--cc=arawinda.p@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=ganeshgr@linux.ibm.com \
--cc=paulus@ozlabs.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.