From: James Smart <jsmart2021@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: James Smart <jsmart2021@gmail.com>
Subject: [PATCH v2 0/3] scsi: add attribute to set lun queue depth on all luns on shost
Date: Thu, 23 Jan 2020 14:20:59 -0800 [thread overview]
Message-ID: <20200123222102.23383-1-jsmart2021@gmail.com> (raw)
There has been a desire to set the lun queue depth on all luns on an
shost. Today that is done by an external script looping through
discovered sdevs and set an sdev attribute. The desire is to have a
single shost attribute that performs this work removing the requirement
for scripting.
This patch:
- Refactors the existing sdev change max queue depth attribute so the
meat of it becomes a service routine.
- Creates a shost helper routine, lldd callable, which cycles though
all sdevs on the shost and changes their max queue depth. Uses the
new service routine.
- Adds a new shost attribute which calls the new shost helper routine.
v2:
Reworked the patch with recommendations on error returns and breaking into
smaller patches. I also had a request to make the shost change routine to
be lldd callable. So switched up how that was implemented as well.
-- james
James Smart (3):
scsi: refactor sdev lun queue depth setting via sysfs
scsi: add shost helper to set max queue depth on all of its devices
scsi: add shost attribute to set max queue depth on all devices on the
shost
drivers/scsi/scsi.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++
drivers/scsi/scsi_priv.h | 1 +
drivers/scsi/scsi_sysfs.c | 27 +++++++++++++++++------
include/scsi/scsi_device.h | 1 +
4 files changed, 77 insertions(+), 6 deletions(-)
--
2.13.7
next reply other threads:[~2020-01-23 22:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 22:20 James Smart [this message]
2020-01-23 22:21 ` [PATCH v2 1/3] scsi: refactor sdev lun queue depth setting via sysfs James Smart
2020-01-24 2:48 ` Bart Van Assche
2020-01-23 22:21 ` [PATCH v2 2/3] scsi: add shost helper to set max queue depth on all of its devices James Smart
2020-01-24 2:52 ` Bart Van Assche
2020-01-23 22:21 ` [PATCH v2 3/3] scsi: add shost attribute to set max queue depth on all devices on the shost James Smart
2020-01-24 2:55 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123222102.23383-1-jsmart2021@gmail.com \
--to=jsmart2021@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.