From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Bhagavathi Perumal S <bperumal@codeaurora.org>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
ath11k@lists.infradead.org, John Crispin <john@phrozen.org>,
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
Subject: Re: [PATCH v2] ath11k: fix up some error paths
Date: Sun, 26 Jan 2020 10:51:41 +0000 (UTC) [thread overview]
Message-ID: <20200126105142.07E49C43383@smtp.codeaurora.org> (raw)
In-Reply-To: <20200115174652.dvkmznhfvjaoc47l@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> There are two error paths where "ret" wasn't set. Also one error path
> we set the error code to -EINVAL but we should just preserve the error
> code from ath11k_hal_srng_get_entrysize(). That function only returns
> -EINVAL so this doesn't change anything.
>
> I removed the "ret = 0;" initializers so that hopefully GCC will be able
> to detect these sorts of bugs in the future.
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
7195c8747e87 ath11k: fix up some error paths
--
https://patchwork.kernel.org/patch/11335489/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2020-01-26 10:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 10:54 [PATCH] ath11k: fix up some error paths Dan Carpenter
2019-12-13 10:54 ` Dan Carpenter
2019-12-13 10:54 ` Dan Carpenter
2020-01-15 9:19 ` Kalle Valo
2020-01-15 9:19 ` Kalle Valo
2020-01-15 9:19 ` Kalle Valo
2020-01-15 17:46 ` [PATCH v2] " Dan Carpenter
2020-01-15 17:46 ` Dan Carpenter
2020-01-15 17:46 ` Dan Carpenter
2020-01-26 10:51 ` Kalle Valo
2020-01-26 10:51 ` Kalle Valo
2020-01-26 10:51 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126105142.07E49C43383@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=bperumal@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=john@phrozen.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.