All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Kasireddy <vivek.kasireddy@intel.com>
To: <intel-gfx@lists.freedesktop.org>
Subject: [Intel-gfx] [PATCH] drm/i915/hotplug: Use phy to get the hpd_pin instead of the port
Date: Wed, 29 Jan 2020 14:47:29 -0800	[thread overview]
Message-ID: <20200129224729.4684-1-vivek.kasireddy@intel.com> (raw)

On some platforms such as Elkhart Lake, although we may use DDI D
to drive a connector, we have to use PHY A (Combo Phy PORT A) to
detect the hotplug interrupts as per the spec because there is no
one-to-one mapping between DDIs and PHYs. Therefore, use the
function intel_port_to_phy() which contains the logic for such
mapping(s) to find the correct hpd_pin.

This change should not affect other platforms as there is always
a one-to-one mapping between DDIs and PHYs.

Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
---
 drivers/gpu/drm/i915/display/intel_hotplug.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
index 042d98bae1ea..491f6b6f920d 100644
--- a/drivers/gpu/drm/i915/display/intel_hotplug.c
+++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
@@ -89,7 +89,8 @@
 enum hpd_pin intel_hpd_pin_default(struct drm_i915_private *dev_priv,
 				   enum port port)
 {
-	switch (port) {
+	enum phy phy = intel_port_to_phy(dev_priv, port);
+	switch (phy) {
 	case PORT_A:
 		return HPD_PORT_A;
 	case PORT_B:
@@ -111,7 +112,7 @@ enum hpd_pin intel_hpd_pin_default(struct drm_i915_private *dev_priv,
 	case PORT_I:
 		return HPD_PORT_I;
 	default:
-		MISSING_CASE(port);
+		MISSING_CASE(phy);
 		return HPD_NONE;
 	}
 }
-- 
2.21.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2020-01-29 22:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 22:47 Vivek Kasireddy [this message]
2020-01-30  3:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hotplug: Use phy to get the hpd_pin instead of the port Patchwork
2020-01-30  3:35 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-01-30 10:37 ` [Intel-gfx] [PATCH] " Jani Nikula
2020-01-30 22:43   ` [Intel-gfx] [PATCH] drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (v2) Vivek Kasireddy
2020-01-30 23:03     ` Souza, Jose
2020-01-31  0:18       ` [Intel-gfx] [PATCH] drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (v3) Vivek Kasireddy
2020-01-31  0:26         ` Souza, Jose
2020-01-31  9:35         ` Jani Nikula
2020-02-04 22:56           ` Vivek Kasireddy
2020-02-29  0:48           ` [Intel-gfx] [PATCH] drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (v4) Vivek Kasireddy
2020-03-02 13:50             ` Ville Syrjälä
2020-03-04 23:42               ` [Intel-gfx] [PATCH] drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (v5) Vivek Kasireddy
2020-01-31  3:36 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (rev3) Patchwork
2020-02-20  0:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (rev4) Patchwork
2020-02-21 23:52 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-02-29  1:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (rev5) Patchwork
2020-03-01 23:54 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-05 13:38 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/hotplug: Use phy to get the hpd_pin instead of the port (rev6) Patchwork
2020-03-05 13:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-06  3:01 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-06 22:40   ` Souza, Jose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200129224729.4684-1-vivek.kasireddy@intel.com \
    --to=vivek.kasireddy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.