Re: [RFC v2] Bluetooth: Add debugfs option to enable runtime debug statements

From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC v2] Bluetooth: Add debugfs option to enable runtime debug statements
Date: Mon, 03 Feb 2020 14:20:02 +0800	[thread overview]
Message-ID: <202002031402.U3dlYcyz%lkp@intel.com> (raw)
In-Reply-To: <20200131220401.27520-1-marcel@holtmann.org>

[-- Attachment #1: Type: text/plain, Size: 3926 bytes --]

Hi Marcel,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on next-20200203]
[cannot apply to bluetooth/master v5.5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Marcel-Holtmann/Bluetooth-Add-debugfs-option-to-enable-runtime-debug-statements/20200203-081756
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: microblaze-randconfig-a001-20200203 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:11:0,
                    from include/linux/list.h:9,
                    from include/linux/wait.h:7,
                    from include/linux/wait_bit.h:8,
                    from include/linux/fs.h:6,
                    from include/linux/debugfs.h:15,
                    from net/bluetooth/lib.c:30:
   net/bluetooth/lib.c: In function 'bt_dbg':
   net/bluetooth/lib.c:243:14: error: 'debug_enable' undeclared (first use in this function); did you mean 'napi_enable'?
     if (likely(!debug_enable))
                 ^
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                       ^~~~
>> net/bluetooth/lib.c:243:2: note: in expansion of macro 'if'
     if (likely(!debug_enable))
     ^~
   include/linux/compiler.h:45:22: note: in expansion of macro '__branch_check__'
    #  define likely(x) (__branch_check__(x, 1, __builtin_constant_p(x)))
                         ^~~~~~~~~~~~~~~~
>> net/bluetooth/lib.c:243:6: note: in expansion of macro 'likely'
     if (likely(!debug_enable))
         ^~~~~~
   net/bluetooth/lib.c:243:14: note: each undeclared identifier is reported only once for each function it appears in
     if (likely(!debug_enable))
                 ^
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
                                                       ^~~~
>> net/bluetooth/lib.c:243:2: note: in expansion of macro 'if'
     if (likely(!debug_enable))
     ^~
   include/linux/compiler.h:45:22: note: in expansion of macro '__branch_check__'
    #  define likely(x) (__branch_check__(x, 1, __builtin_constant_p(x)))
                         ^~~~~~~~~~~~~~~~
>> net/bluetooth/lib.c:243:6: note: in expansion of macro 'likely'
     if (likely(!debug_enable))
         ^~~~~~

vim +/if +243 net/bluetooth/lib.c

   237	
   238	void bt_dbg(const char *format, ...)
   239	{
   240		struct va_format vaf;
   241		va_list args;
   242	
 > 243		if (likely(!debug_enable))
   244			return;
   245	
   246		va_start(args, format);
   247	
   248		vaf.fmt = format;
   249		vaf.va = &args;
   250	
   251		printk(KERN_DEBUG pr_fmt("%pV"), &vaf);
   252	
   253		va_end(args);
   254	}
   255	EXPORT_SYMBOL(bt_dbg);
   256	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30913 bytes --]