From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Wei Liu <wl@xen.org>, Jan Beulich <jbeulich@suse.com>,
"Nakajima, Jun" <jun.nakajima@intel.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 2/4] x86/vvmx: fix VM_EXIT_ACK_INTR_ON_EXIT handling
Date: Tue, 4 Feb 2020 10:26:34 +0100 [thread overview]
Message-ID: <20200204092634.GF4679@Air-de-Roger> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D19D765915@SHSMSX104.ccr.corp.intel.com>
On Tue, Feb 04, 2020 at 01:39:44AM +0000, Tian, Kevin wrote:
> > From: Roger Pau Monne <roger.pau@citrix.com>
> > Sent: Monday, February 3, 2020 8:19 PM
> >
> > When VM_EXIT_ACK_INTR_ON_EXIT is set in the vmexit control vmcs
>
> set->cleared
>
> > register the bit 31 of VM_EXIT_INTR_INFO must be 0, in order to denote
> > that the field doesn't contain any interrupt information. This is not
> > currently acknowledged as the field always get filled with valid
> > interrupt information, regardless of whether VM_EXIT_ACK_INTR_ON_EXIT
> > is set.
> >
> > Fix this and only fill VM_EXIT_INTR_INFO when VM_EXIT_ACK_INTR_ON_EXIT
> > is not set. Note that this requires one minor change in
>
> not set -> set
>
> > nvmx_update_apicv in order to obtain the interrupt information from
> > the internal state rather than the nested vmcs register.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>
> with above fixed,
Ouch yes, I've inverted the conditions. Thanks for noticing.
>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
To whoever picks this patch for committing: let me know if you would
like me to resend with the commit log fixed.
Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-02-04 9:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 12:19 [Xen-devel] [PATCH v2 0/4] x86/vvmx: fixes to interrupt injection Roger Pau Monne
2020-02-03 12:19 ` [Xen-devel] [PATCH v2 1/4] x86/vvmx: fix virtual interrupt injection when Ack on exit control is used Roger Pau Monne
2020-02-04 1:35 ` Tian, Kevin
2020-02-04 9:23 ` Roger Pau Monné
2020-02-04 9:49 ` Jan Beulich
2020-02-04 10:05 ` Tian, Kevin
2020-02-03 12:19 ` [Xen-devel] [PATCH v2 2/4] x86/vvmx: fix VM_EXIT_ACK_INTR_ON_EXIT handling Roger Pau Monne
2020-02-04 1:39 ` Tian, Kevin
2020-02-04 9:26 ` Roger Pau Monné [this message]
2020-02-03 12:19 ` [Xen-devel] [PATCH v2 3/4] x86/vvmx: don't enable interrupt window when using virt intr delivery Roger Pau Monne
2020-02-04 1:40 ` Tian, Kevin
2020-02-03 12:19 ` [Xen-devel] [PATCH v2 4/4] Revert "tools/libxc: disable x2APIC when using nested virtualization" Roger Pau Monne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204092634.GF4679@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.