Re: [RFC PATCH 3/7] vfio/pci: Introduce VF token

From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH 3/7] vfio/pci: Introduce VF token
Date: Wed, 05 Feb 2020 12:19:34 +0800	[thread overview]
Message-ID: <202002051248.1MbLORFN%lkp@intel.com> (raw)
In-Reply-To: <158085756068.9445.6284766069491778316.stgit@gimli.home>

[-- Attachment #1: Type: text/plain, Size: 3544 bytes --]

Hi Alex,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on vfio/next]
[also build test ERROR on pci/next linux/master linus/master v5.5 next-20200204]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Alex-Williamson/vfio-pci-SR-IOV-support/20200205-071242
base:   https://github.com/awilliam/linux-vfio.git next
config: s390-defconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/vfio/pci/vfio_pci.c: In function 'vfio_pci_vf_token_user_add':
>> drivers/vfio/pci/vfio_pci.c:476:49: error: 'struct pci_dev' has no member named 'physfn'; did you mean 'is_physfn'?
     pf_dev = vfio_device_get_from_dev(&vdev->pdev->physfn->dev);
                                                    ^~~~~~
                                                    is_physfn
   drivers/vfio/pci/vfio_pci.c:480:33: error: 'struct pci_dev' has no member named 'physfn'; did you mean 'is_physfn'?
     if (pci_dev_driver(vdev->pdev->physfn) != &vfio_pci_driver) {
                                    ^~~~~~
                                    is_physfn
   drivers/vfio/pci/vfio_pci.c: In function 'vfio_pci_match':
   drivers/vfio/pci/vfio_pci.c:1354:42: error: 'struct pci_dev' has no member named 'physfn'; did you mean 'is_physfn'?
       vfio_device_get_from_dev(&vdev->pdev->physfn->dev);
                                             ^~~~~~
                                             is_physfn
   drivers/vfio/pci/vfio_pci.c:1357:35: error: 'struct pci_dev' has no member named 'physfn'; did you mean 'is_physfn'?
       if (pci_dev_driver(vdev->pdev->physfn) ==
                                      ^~~~~~
                                      is_physfn
   drivers/vfio/pci/vfio_pci.c: In function 'vfio_pci_probe':
>> drivers/vfio/pci/vfio_pci.c:1458:10: error: 'struct pci_dev' has no member named 'sriov'
     if (pdev->sriov) {
             ^~

vim +476 drivers/vfio/pci/vfio_pci.c

   467	
   468	static void vfio_pci_vf_token_user_add(struct vfio_pci_device *vdev, int val)
   469	{
   470		struct vfio_device *pf_dev;
   471		struct vfio_pci_device *pf_vdev;
   472	
   473		if (!vdev->pdev->is_virtfn)
   474			return;
   475	
 > 476		pf_dev = vfio_device_get_from_dev(&vdev->pdev->physfn->dev);
   477		if (!pf_dev)
   478			return;
   479	
   480		if (pci_dev_driver(vdev->pdev->physfn) != &vfio_pci_driver) {
   481			vfio_device_put(pf_dev);
   482			return;
   483		}
   484	
   485		pf_vdev = vfio_device_data(pf_dev);
   486	
   487		mutex_lock(&pf_vdev->vf_token->lock);
   488		pf_vdev->vf_token->users += val;
   489		mutex_unlock(&pf_vdev->vf_token->lock);
   490	
   491		vfio_device_put(pf_dev);
   492	}
   493	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 18760 bytes --]