From: Andrew Jones <drjones@redhat.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, Alexandru Elisei <alexandru.elisei@arm.com>,
Drew Jones <drjones@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>
Subject: [PULL kvm-unit-tests 01/10] Makefile: Use no-stack-protector compiler options
Date: Thu, 6 Feb 2020 17:24:25 +0100 [thread overview]
Message-ID: <20200206162434.14624-2-drjones@redhat.com> (raw)
In-Reply-To: <20200206162434.14624-1-drjones@redhat.com>
From: Alexandru Elisei <alexandru.elisei@arm.com>
Let's fix the typos so that the -fno-stack-protector and
-fno-stack-protector-all compiler options are actually used.
Tested by compiling for arm64, x86_64 and ppc64 little endian. Before the
patch, the arguments were missing from the gcc invocation; after the patch,
they were present. Also fixes a compilation error that I was seeing with
aarch64 gcc version 9.2.0, where the linker was complaining about an
undefined reference to the symbol __stack_chk_guard.
Fixes: e5c73790f5f0 ("build: don't reevaluate cc-option shell command")
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Drew Jones <drjones@redhat.com>
CC: Laurent Vivier <lvivier@redhat.com>
CC: Thomas Huth <thuth@redhat.com>
CC: David Hildenbrand <david@redhat.com>
CC: Janosch Frank <frankja@linux.ibm.com>
Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 767b6c6a51d0..754ed65ecd2f 100644
--- a/Makefile
+++ b/Makefile
@@ -55,8 +55,8 @@ COMMON_CFLAGS += -Wignored-qualifiers -Werror
frame-pointer-flag=-f$(if $(KEEP_FRAME_POINTER),no-,)omit-frame-pointer
fomit_frame_pointer := $(call cc-option, $(frame-pointer-flag), "")
-fnostack_protector := $(call cc-option, -fno-stack-protector, "")
-fnostack_protector_all := $(call cc-option, -fno-stack-protector-all, "")
+fno_stack_protector := $(call cc-option, -fno-stack-protector, "")
+fno_stack_protector_all := $(call cc-option, -fno-stack-protector-all, "")
wno_frame_address := $(call cc-option, -Wno-frame-address, "")
fno_pic := $(call cc-option, -fno-pic, "")
no_pie := $(call cc-option, -no-pie, "")
--
2.21.1
next prev parent reply other threads:[~2020-02-06 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 16:24 [PULL kvm-unit-tests 00/10] arm/arm64: Various fixes Andrew Jones
2020-02-06 16:24 ` Andrew Jones [this message]
2020-02-06 16:24 ` [PULL kvm-unit-tests 02/10] arm/arm64: psci: Don't run C code without stack or vectors Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 03/10] arm64: timer: Add ISB after register writes Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 04/10] arm64: timer: Add ISB before reading the counter value Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 05/10] arm64: timer: Make irq_received volatile Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 06/10] arm64: timer: EOIR the interrupt after masking the timer Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 07/10] arm64: timer: Wait for the GIC to sample timer interrupt state Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 08/10] arm64: timer: Check the " Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 09/10] arm64: timer: Test behavior when timer disabled or masked Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 10/10] arm/arm64: Perform dcache clean + invalidate after turning MMU off Andrew Jones
2020-03-17 12:10 ` [PULL kvm-unit-tests 00/10] arm/arm64: Various fixes Alexandru Elisei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206162434.14624-2-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=alexandru.elisei@arm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.