From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Ronald Tschalär" <ronald@innovation.ch>
Cc: Rob Herring <robh@kernel.org>, Jiri Slaby <jslaby@suse.com>,
Maximilian Luz <luzmaximilian@gmail.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] serdev: Fix detection of UART devices on Apple machines.
Date: Wed, 19 Feb 2020 12:15:19 +0100 [thread overview]
Message-ID: <20200219111519.GB2814125@kroah.com> (raw)
In-Reply-To: <20200211194723.486217-1-ronald@innovation.ch>
On Tue, Feb 11, 2020 at 11:47:23AM -0800, Ronald Tschalär wrote:
> On Apple devices the _CRS method returns an empty resource template, and
> the resource settings are instead provided by the _DSM method. But
> commit 33364d63c75d6182fa369cea80315cf1bb0ee38e (serdev: Add ACPI
> devices by ResourceSource field) changed the search for serdev devices
> to require valid, non-empty resource template, thereby breaking Apple
> devices and causing bluetooth devices to not be found.
>
> This expands the check so that if we don't find a valid template, and
> we're on an Apple machine, then just check for the device being an
> immediate child of the controller and having a "baud" property.
>
> Cc: <stable@vger.kernel.org> # 5.5
> Signed-off-by: Ronald Tschalär <ronald@innovation.ch>
> ---
> drivers/tty/serdev/core.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> index ce5309d00280..0f64a10ba51f 100644
> --- a/drivers/tty/serdev/core.c
> +++ b/drivers/tty/serdev/core.c
> @@ -18,6 +18,7 @@
> #include <linux/sched.h>
> #include <linux/serdev.h>
> #include <linux/slab.h>
> +#include <linux/platform_data/x86/apple.h>
Why is this needed? Just for the x86_apple_machine variable?
Why do we still have platform_data for new systems anymore? Can't this
go into a much more generic location? Like as an inline function?
thanks,
greg k-h
next prev parent reply other threads:[~2020-02-19 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 19:47 [PATCH] serdev: Fix detection of UART devices on Apple machines Ronald Tschalär
2020-02-19 11:15 ` Greg Kroah-Hartman [this message]
2020-02-20 6:33 ` Life is hard, and then you die
2020-02-20 6:47 ` Greg Kroah-Hartman
2020-02-23 8:22 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219111519.GB2814125@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=robh@kernel.org \
--cc=ronald@innovation.ch \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.