All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Julien Grall <julien@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	xen-devel@lists.xenproject.org,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_*
Date: Wed, 19 Feb 2020 12:41:18 +0100	[thread overview]
Message-ID: <20200219114118.GZ4679@Air-de-Roger> (raw)
In-Reply-To: <c0a6422b-c664-2967-94c9-a4b2698e28c0@xen.org>

On Wed, Feb 19, 2020 at 11:35:16AM +0000, Julien Grall wrote:
> Hi Roger,
> 
> On 19/02/2020 10:22, Roger Pau Monne wrote:
> > So BIT_WORD can be imported from Linux. The difference between current
> > Linux implementation of BIT_WORD is that the size of the word unit is
> > a long integer, while the Xen one is hardcoded to 32 bits.
> > 
> > Current users of BITOP_WORD on Arm (which considers a word a long
> > integer) are switched to use the generic BIT_WORD which also operates
> > on long integers.
> > 
> > No functional change intended.
> > 
> > Suggested-by: Julien Grall <julien@xen.org>
> > Suggested-by: Jan Beulich <jbeulich@suse.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> 
> Acked-by: Julien Grall <julien@xen.org>
> 
> Did you build test it on Arm?

Did a gitlab run, build was fine:

https://gitlab.com/xen-project/people/royger/xen/pipelines/118878544

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2020-02-19 11:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19 10:22 [Xen-devel] [PATCH v6 0/3] nvmx: implement support for MSR bitmaps Roger Pau Monne
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 1/3] arm: rename BIT_{WORD/MASK/PER_WORD) to BITOP_* Roger Pau Monne
2020-02-19 11:35   ` Julien Grall
2020-02-19 11:41     ` Roger Pau Monné [this message]
2020-02-19 12:03       ` Julien Grall
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 2/3] bitmap: import bitmap_{set/clear} from Linux 5.5 Roger Pau Monne
2020-02-19 10:22 ` [Xen-devel] [PATCH v6 3/3] nvmx: always trap accesses to x2APIC MSRs Roger Pau Monne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200219114118.GZ4679@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.