From: Richard Leitner <richard.leitner@skidata.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: <fancer.lancer@gmail.com>, <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <kernel@pengutronix.de>
Subject: Re: [PATCH] usb: usb251xb: fix regulator probe and error handling
Date: Wed, 26 Feb 2020 09:01:53 +0100 [thread overview]
Message-ID: <20200226080153.GA673633@pcleri> (raw)
In-Reply-To: <20200226072644.18490-1-m.felsch@pengutronix.de>
On Wed, Feb 26, 2020 at 08:26:44AM +0100, Marco Felsch wrote:
> Commit 4d7201cda226 ("usb: usb251xb: add vdd supply support") didn't
> covered the non-DT use-case and so the regualtor_enable() call during
> probe will fail on those platforms. Also the commit didn't handled the
> error case correctly.
>
> Move devm_regulator_get() out of usb251xb_get_ofdata() to address the
> 1st issue. This can be done without worries because devm_regulator_get()
> handles the non-DT use-case too. Add devm_add_action_or_reset() to
> address the 2nd bug.
>
> Fixes: 4d7201cda226 ("usb: usb251xb: add vdd supply support")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
Looks fine to me.
Acked-by: Richard Leitner <richard.leitner@skidata.com>
> Hi,
>
> unfortunately I didn't covered the non-DT use case during the devel of
> commit 4d7201cda226 and I was a bit to optimistic so I also missed the
> error handling.
>
> Regards,
> Marco
>
> drivers/usb/misc/usb251xb.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
regards;rl
prev parent reply other threads:[~2020-02-26 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 7:26 [PATCH] usb: usb251xb: fix regulator probe and error handling Marco Felsch
2020-02-26 8:01 ` Richard Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226080153.GA673633@pcleri \
--to=richard.leitner@skidata.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-usb@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.