From: Tony Lindgren <tony@atomide.com>
To: Suman Anna <s-anna@ti.com>, Rob Herring <robh@kernel.org>
Cc: Roger Quadros <rogerq@ti.com>, Tero Kristo <t-kristo@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 01/12] dt-bindings: bus: ti-sysc: Add support for PRUSS SYSC type
Date: Wed, 26 Feb 2020 10:31:32 -0800 [thread overview]
Message-ID: <20200226183132.GV37466@atomide.com> (raw)
In-Reply-To: <b35e278d-c3dd-3356-93c3-0511d3164d7a@ti.com>
* Suman Anna <s-anna@ti.com> [200226 16:39]:
> Hi Roger,
>
> On 2/26/20 2:42 AM, Roger Quadros wrote:
> > Hi Suman,
> >
> > On 25/02/2020 22:46, Suman Anna wrote:
> >> From: Roger Quadros <rogerq@ti.com>
> >>
> >> The PRUSS module has a SYSCFG which is unique. The SYSCFG
> >> has two additional unique fields called STANDBY_INIT and
> >> SUB_MWAIT in addition to regular IDLE_MODE and STANDBY_MODE
> >> fields. Add the bindings for this new sysc type.
> >>
> >> Signed-off-by: Roger Quadros <rogerq@ti.com>
> >> Signed-off-by: Suman Anna <s-anna@ti.com>
> >> ---
> >> Documentation/devicetree/bindings/bus/ti-sysc.txt | 1 +
> >> include/dt-bindings/bus/ti-sysc.h | 4 ++++
> >> 2 files changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> b/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> index 233eb8294204..c984143d08d2 100644
> >> --- a/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> +++ b/Documentation/devicetree/bindings/bus/ti-sysc.txt
> >> @@ -38,6 +38,7 @@ Required standard properties:
> >> "ti,sysc-dra7-mcasp"
> >> "ti,sysc-usb-host-fs"
> >> "ti,sysc-dra7-mcan"
> >> + "ti,sysc-pruss"
> >> - reg shall have register areas implemented for the
> >> interconnect
> >> target module in question such as revision, sysc and syss
> >> diff --git a/include/dt-bindings/bus/ti-sysc.h
> >> b/include/dt-bindings/bus/ti-sysc.h
> >
> > Did you intentionally leave this here? It should be part of 2nd patch?
>
> No, not really, include/bindings are also considered part of bindings.
> This patch alone should be enough for you to add the DT nodes.
Well I don't care either way, sort of would prefer to have this
with the device patch in case somebody starts back porting
driver changes.
Anyways, let's wayt for Rob's ack on this, maybe he has also
preference on the ti-sysc.h changes.
Regards,
Tony
next prev parent reply other threads:[~2020-02-26 18:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 20:46 [PATCH 00/12] ti-sysc support for PRUSS Suman Anna
2020-02-25 20:46 ` [PATCH 01/12] dt-bindings: bus: ti-sysc: Add support for PRUSS SYSC type Suman Anna
2020-02-26 8:42 ` Roger Quadros
2020-02-26 16:38 ` Suman Anna
2020-02-26 18:31 ` Tony Lindgren [this message]
2020-02-25 20:46 ` [PATCH 02/12] " Suman Anna
2020-02-25 20:46 ` [PATCH 03/12] ARM: dts: AM33xx-l4: Update PRUSS interconnect target-module node Suman Anna
2020-02-25 20:46 ` [PATCH 04/12] ARM: dts: AM4372: Add the PRU-ICSS " Suman Anna
2020-02-25 20:46 ` [PATCH 05/12] ARM: dts: dra7: Add PRU-ICSS interconnect target-module nodes Suman Anna
2020-02-25 20:46 ` [PATCH 06/12] ARM: dts: am335x-bone-common: Enable PRU-ICSS interconnect node Suman Anna
2020-02-26 18:29 ` Tony Lindgren
2020-02-26 20:34 ` Suman Anna
2020-02-26 22:37 ` Tony Lindgren
2020-02-26 22:39 ` Tony Lindgren
2020-02-27 0:58 ` Suman Anna
2020-02-27 2:07 ` Tony Lindgren
2020-02-27 21:28 ` Suman Anna
2020-02-27 21:30 ` Tony Lindgren
2020-02-25 20:46 ` [PATCH 07/12] ARM: dts: am335x-evm: " Suman Anna
2020-02-25 20:46 ` [PATCH 08/12] ARM: dts: am335x-evmsk: " Suman Anna
2020-02-25 20:46 ` [PATCH 09/12] ARM: dts: am335x-icev2: " Suman Anna
2020-02-25 20:46 ` [PATCH 10/12] ARM: dts: am437x-gp-evm: " Suman Anna
2020-02-25 20:46 ` [PATCH 11/12] ARM: dts: am437x-sk: " Suman Anna
2020-02-25 20:46 ` [PATCH 12/12] ARM: dts: am437x-idk: " Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226183132.GV37466@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@ti.com \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.