From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eric Auger <eric.auger@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 4/5] KVM: Kick resamplefd for split kernel irqchip
Date: Fri, 28 Feb 2020 09:58:00 -0500 [thread overview]
Message-ID: <20200228145800.GR180973@xz-x1> (raw)
In-Reply-To: <0c8147b1-ee26-cd5d-1592-f07371feaeb8@redhat.com>
On Fri, Feb 28, 2020 at 11:34:46AM +0100, Paolo Bonzini wrote:
> On 26/02/20 23:55, Peter Xu wrote:
> > +
> > + /* Kick resamplefd if KVM is bypassed */
> > + kvm_resample_fd_notify(n);
>
> This is only needed for level-triggered interrupts, so it can be placed
> below the test.
Yes I was thinking it the same way, however... I noticed that VFIO
will even mask edge INTx after getting IRQ (vfio_intx_handler). And
if look into current KVM kernel implementation, it has done the same
logic to ack edge triggerred irqs (kvm_ioapic_update_eoi_one), we
should logically ack it here too even for edge-triggered?
Thanks,
>
> Paolo
>
> > + if (((entry >> IOAPIC_LVT_TRIGGER_MODE_SHIFT) & 1) !=
> > + IOAPIC_TRIGGER_LEVEL) {
> > continue;
>
--
Peter Xu
next prev parent reply other threads:[~2020-02-28 14:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 22:50 [PATCH 0/5] vfio/pci: Fix up breakage against split irqchip and INTx Peter Xu
2020-02-26 22:50 ` [PATCH 1/5] vfio/pci: Disable INTx fast path if using split irqchip Peter Xu
2020-02-27 16:53 ` Auger Eric
2020-02-27 17:10 ` Peter Xu
2020-02-26 22:50 ` [PATCH 2/5] vfio/pci: Use kvm_irqchip_add_irqfd_notifier_gsi() for irqfds Peter Xu
2020-02-27 11:04 ` Auger Eric
2020-02-27 16:41 ` Cornelia Huck
2020-02-26 22:54 ` [PATCH 3/5] KVM: Pass EventNotifier into kvm_irqchip_assign_irqfd Peter Xu
2020-02-27 17:01 ` Auger Eric
2020-02-26 22:55 ` [PATCH 4/5] KVM: Kick resamplefd for split kernel irqchip Peter Xu
2020-02-27 17:00 ` [PATCH v1.1 " Peter Xu
2020-02-27 17:18 ` Peter Xu
2020-02-27 17:42 ` Auger Eric
2020-02-27 18:00 ` Peter Xu
2020-02-27 18:22 ` Auger Eric
2020-02-27 19:19 ` Peter Xu
2020-02-27 21:14 ` Auger Eric
2020-02-27 21:52 ` Peter Xu
2020-02-28 10:34 ` Paolo Bonzini
2020-02-28 10:36 ` Auger Eric
2020-02-28 10:34 ` [PATCH " Paolo Bonzini
2020-02-28 14:58 ` Peter Xu [this message]
2020-02-28 15:24 ` Paolo Bonzini
2020-02-26 22:55 ` [PATCH 5/5] Revert "vfio/pci: Disable INTx fast path if using split irqchip" Peter Xu
2020-02-27 15:32 ` [PATCH 0/5] vfio/pci: Fix up breakage against split irqchip and INTx Auger Eric
2020-02-27 15:51 ` Peter Xu
2020-02-27 17:02 ` Peter Xu
2020-02-28 10:36 ` Paolo Bonzini
2020-02-28 15:25 ` Peter Xu
2020-02-28 15:32 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228145800.GR180973@xz-x1 \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.