Re: [PATCH] config.mak.dev: re-enable -Wformat-zero-length

From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ralf Thielow via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Alban Gruin <alban.gruin@gmail.com>,
	Ralf Thielow <ralf.thielow@gmail.com>
Subject: Re: [PATCH] config.mak.dev: re-enable -Wformat-zero-length
Date: Fri, 28 Feb 2020 12:06:41 -0500	[thread overview]
Message-ID: <20200228170641.GA1405401@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqtv3aek8o.fsf@gitster-ct.c.googlers.com>

On Fri, Feb 28, 2020 at 08:42:47AM -0800, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > The short of it is that we probably can't just disable the warning for
> > everybody because of portability issues. And ignoring it for developers
> > puts us in the situation we're in now, where non-dev builds are annoyed.
> 
> "git blame" unfortunately is very bad at poing at a commit that
> removed something, so I do not offhand know how much it would help
> readers who later wonder "oh, I am sure we had thing to disable
> format-zero-length warning, and I want to learn the reason why we
> dropped it", but thanks for writing this down.

I often turn to "git log -Sformat-zero" for this (and in fact that was
very useful for the research I did yesterday). But of course you have to
first _know_ about the warning and wonder "hey, didn't used ignore it?"
for that to be useful.

-Peff