From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Roy Im <roy.im.opensource@diasemi.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Brian Masney <masneyb@onstation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>, Luca Weiss <luca@z3ntu.xyz>,
Maximilian Luz <luzmaximilian@gmail.com>,
Pascal PAILLET-LME <p.paillet@st.com>,
Rob Herring <robh@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Support Opensource <Support.Opensource@diasemi.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH V9 3/3] Input: new da7280 haptic driver
Date: Mon, 2 Mar 2020 07:43:57 +0100 [thread overview]
Message-ID: <20200302064357.ke57i2wchulph5f7@pengutronix.de> (raw)
In-Reply-To: <VE1PR10MB30856D67BB5ED36BED574FBF85E70@VE1PR10MB3085.EURPRD10.PROD.OUTLOOK.COM>
Hey Roy,
On Mon, Mar 02, 2020 at 01:52:30AM +0000, Roy Im wrote:
> On Monday, March 2, 2020 6:20 AM, Uwe Kleine-König wrote:
> > On Sat, Feb 29, 2020 at 12:59:20AM +0000, Roy Im wrote:
> > > Okay, thanks. I have tried to update that as below.
> > > Could I get your comment if you still see anything on this?
> > >
> > > /* Maximum gain is 0x7fff for PWM mode */
> > > #define MAX_MAGNITUDE_SHIFT 15
> > > [...]
> > > period_mag_multi >>= MAX_MAGNITUDE_SHIFT;
> > >
> > > /* The interpretation of duty cycle depends on the acc_en,
> > > * it should be from 50% to 100% for acc_en = 0.
> > > * See datasheet 'PWM mode' section for more details.
> > > */
> > > if (!haptics->acc_en) {
> > > period_mag_multi += state.period;
> > > period_mag_multi /= 2;
> > > }
> >
> > Much better. Extra points if you add a link to the datasheet at the top of the driver. I didn't look at the datasheet and
> > assume that the reasoning is obvious then.
>
> Okay, then do you think it would be better to remove that comment(the 3rd line - datasheet)?.
No, please keep the reference.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-03-02 6:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 7:27 [PATCH V9 0/3] da7280: haptic driver submission Roy Im
2020-02-21 7:27 ` [PATCH V9 3/3] Input: new da7280 haptic driver Roy Im
2020-02-21 7:27 ` Roy Im
2020-02-26 16:13 ` Uwe Kleine-König
2020-02-29 0:59 ` Roy Im
2020-03-01 21:20 ` Uwe Kleine-König
2020-03-02 1:52 ` Roy Im
2020-03-02 6:43 ` Uwe Kleine-König [this message]
2020-03-02 8:58 ` Roy Im
2020-02-21 7:27 ` [PATCH V9 2/3] dt-bindings: input: Add document bindings for DA7280 Roy Im
2020-02-21 7:27 ` [PATCH V9 1/3] MAINTAINERS: da7280 updates to the Dialog Semiconductor search terms Roy Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302064357.ke57i2wchulph5f7@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Support.Opensource@diasemi.com \
--cc=bgolaszewski@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=luzmaximilian@gmail.com \
--cc=masneyb@onstation.org \
--cc=p.paillet@st.com \
--cc=robh@kernel.org \
--cc=roy.im.opensource@diasemi.com \
--cc=sameo@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.