From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/7] xfs: introduce new private btree cursor names
Date: Wed, 4 Mar 2020 18:29:01 -0800 [thread overview]
Message-ID: <20200305022901.GP8045@magnolia> (raw)
In-Reply-To: <20200305014537.11236-2-david@fromorbit.com>
On Thu, Mar 05, 2020 at 12:45:31PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Just the defines of the new names - the conversion will be in
> scripted commits after this.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/libxfs/xfs_btree.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/xfs/libxfs/xfs_btree.h b/fs/xfs/libxfs/xfs_btree.h
> index 3eff7c321d43..bd5a2bfca64e 100644
> --- a/fs/xfs/libxfs/xfs_btree.h
> +++ b/fs/xfs/libxfs/xfs_btree.h
> @@ -224,6 +224,8 @@ typedef struct xfs_btree_cur
> #define XFS_BTCUR_BPRV_INVALID_OWNER (1<<1) /* for ext swap */
> } b;
> } bc_private; /* per-btree type data */
> +#define bc_ag bc_private.a
> +#define bc_bt bc_private.b
Hm. I get that the historical meaning of "b" was for "bmbt", but it's
not a great descriptor since the fields in bc_private.b are really for
inode-rooted btrees, of which the bmbt is currently the only user. If
we ever get around to adding the realtime rmapbt, then "bc_bt" is going
to seem a bit anachronistic.
bc_ino, perhaps?
--D
> } xfs_btree_cur_t;
>
> /* cursor flags */
> --
> 2.24.0.rc0
>
next prev parent reply other threads:[~2020-03-05 2:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 1:45 [PATCH 0/7] xfs: make btree cursor private unions anonymous Dave Chinner
2020-03-05 1:45 ` [PATCH 1/7] xfs: introduce new private btree cursor names Dave Chinner
2020-03-05 2:29 ` Darrick J. Wong [this message]
2020-03-05 2:47 ` Dave Chinner
2020-03-05 1:45 ` [PATCH 2/7] xfs: convert btree cursor ag private member name Dave Chinner
2020-03-05 2:31 ` Darrick J. Wong
2020-03-05 2:43 ` Dave Chinner
2020-03-05 1:45 ` [PATCH 3/7] xfs: convert btree cursor btree " Dave Chinner
2020-03-05 1:45 ` [PATCH 4/7] xfs: rename btree cursur private btree member flags Dave Chinner
2020-03-05 2:08 ` Darrick J. Wong
2020-03-05 2:29 ` Dave Chinner
2020-03-05 1:45 ` [PATCH 5/7] xfs: make btree cursor private union anonymous Dave Chinner
2020-03-05 1:45 ` [PATCH 6/7] xfs: make the btree cursor union members named structure Dave Chinner
2020-03-05 1:45 ` [PATCH 7/7] xfs: make the btree ag cursor private union anonymous Dave Chinner
2020-03-12 3:44 [PATCH v2 0/7] xfs: make btree cursor private unions anonymous Darrick J. Wong
2020-03-12 3:44 ` [PATCH 1/7] xfs: introduce new private btree cursor names Darrick J. Wong
2020-03-12 10:41 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305022901.GP8045@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.