From: Kees Cook <keescook@chromium.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Joe Perches <joe@perches.com>,
Federico Vaga <federico.vaga@vaga.pv.it>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: deprecated.rst: Clean up fall-through details
Date: Tue, 10 Mar 2020 12:22:21 -0700 [thread overview]
Message-ID: <202003101221.A1388D0C@keescook> (raw)
In-Reply-To: <20200310112356.1b5b32f2@lwn.net>
On Tue, Mar 10, 2020 at 11:23:56AM -0600, Jonathan Corbet wrote:
> On Wed, 4 Mar 2020 11:03:24 -0800
> Kees Cook <keescook@chromium.org> wrote:
>
> > Add example of fall-through, list-ify the case ending statements, and
> > adjust the markup for links and readability. While here, adjust
> > strscpy() details to mention strscpy_pad().
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Applied, thanks. But ...
>
> > ---
> > Documentation/process/deprecated.rst | 48 +++++++++++++++++-----------
> > 1 file changed, 29 insertions(+), 19 deletions(-)
> >
> > diff --git a/Documentation/process/deprecated.rst b/Documentation/process/deprecated.rst
> > index 179f2a5625a0..f9f196d3a69b 100644
> > --- a/Documentation/process/deprecated.rst
> > +++ b/Documentation/process/deprecated.rst
> > @@ -94,8 +94,8 @@ and other misbehavior due to the missing termination. It also NUL-pads the
> > destination buffer if the source contents are shorter than the destination
> > buffer size, which may be a needless performance penalty for callers using
> > only NUL-terminated strings. The safe replacement is :c:func:`strscpy`.
> > -(Users of :c:func:`strscpy` still needing NUL-padding will need an
> > -explicit :c:func:`memset` added.)
> > +(Users of :c:func:`strscpy` still needing NUL-padding should instead
> > +use strscpy_pad().)
>
> :c:func: usage should really be stomped on when we encounter it. There's
> a few in this file; I'll tack on a quick patch making them go away.
Oops, yes, I meant to do another pass for that. I will double-check
future patches!
--
Kees Cook
prev parent reply other threads:[~2020-03-10 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 19:03 [PATCH] docs: deprecated.rst: Clean up fall-through details Kees Cook
2020-03-04 19:30 ` Gustavo A. R. Silva
2020-03-10 17:23 ` Jonathan Corbet
2020-03-10 19:22 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202003101221.A1388D0C@keescook \
--to=keescook@chromium.org \
--cc=corbet@lwn.net \
--cc=federico.vaga@vaga.pv.it \
--cc=gustavo@embeddedor.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.