From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Oder Chiou <oder_chiou@realtek.com>,
broonie@kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
kbuild test robot <lkp@intel.com>
Subject: [PATCH 1/3] ASoC: rt5682: fix unmet dependencies
Date: Tue, 10 Mar 2020 11:35:07 -0500 [thread overview]
Message-ID: <20200310163509.14466-2-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200310163509.14466-1-pierre-louis.bossart@linux.intel.com>
The rt5682 code can be used in I2C or SoundWire mode. When I2C is not
selected, we have the following issue:
WARNING: unmet direct dependencies detected for SND_SOC_RT5682
Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] &&
I2C [=n]
Selected by [m]:
- SND_SOC_RT5682_SDW [=m] && SOUND [=m] && !UML && SND [=m] &&
SND_SOC [=m] && SOUNDWIRE [=m]
Fix by adding SOUNDWIRE as a dependency.
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 03f6fc6de9192f ('ASoC: rt5682: Add the soundwire support')
Cc: Oder Chiou <oder_chiou@realtek.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 6aee70ed43df..78be69e9b618 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -1135,7 +1135,7 @@ config SND_SOC_RT5677_SPI
config SND_SOC_RT5682
tristate
- depends on I2C
+ depends on I2C || SOUNDWIRE
config SND_SOC_RT5682_SDW
tristate "Realtek RT5682 Codec - SDW"
--
2.20.1
next prev parent reply other threads:[~2020-03-10 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 16:35 [PATCH 0/3] ASoC: rt5682: fix Kconfig/compilation issues when I2C is not selected Pierre-Louis Bossart
2020-03-10 16:35 ` Pierre-Louis Bossart [this message]
2020-03-10 18:19 ` Applied "ASoC: rt5682: fix unmet dependencies" to the asoc tree Mark Brown
2020-03-10 16:35 ` [PATCH 2/3] ASoC: rt5682: fix compilation issues without I2C Pierre-Louis Bossart
2020-03-10 17:19 ` Mark Brown
2020-03-10 18:50 ` Pierre-Louis Bossart
2020-03-10 16:35 ` [PATCH 3/3] ASoC: rt5682-sdw: fix 'defined but not used' pm functions Pierre-Louis Bossart
2020-03-10 18:19 ` Applied "ASoC: rt5682-sdw: fix 'defined but not used' pm functions" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310163509.14466-2-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lkp@intel.com \
--cc=oder_chiou@realtek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.