Re: [PATCH 3/4] powerpc/xmon: Add source flags to output of XIVE interrupts

From: Greg Kurz <groug@kaod.org>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/4] powerpc/xmon: Add source flags to output of XIVE interrupts
Date: Tue, 10 Mar 2020 16:43:33 +0100	[thread overview]
Message-ID: <20200310164333.11e7e62b@bahia.home> (raw)
In-Reply-To: <20200306150143.5551-4-clg@kaod.org>

On Fri,  6 Mar 2020 16:01:42 +0100
Cédric Le Goater <clg@kaod.org> wrote:

> Some firmwares or hypervisors can advertise different source
> characteristics. Track their value under XMON. What we are mostly
> interested in is the StoreEOI flag.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Greg Kurz <groug@kaod.org>

>  arch/powerpc/sysdev/xive/common.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
> index 8155adc2225a..c865ae554605 100644
> --- a/arch/powerpc/sysdev/xive/common.c
> +++ b/arch/powerpc/sysdev/xive/common.c
> @@ -283,7 +283,10 @@ int xmon_xive_get_irq_config(u32 hw_irq, struct irq_data *d)
>  		struct xive_irq_data *xd = irq_data_get_irq_handler_data(d);
>  		u64 val = xive_esb_read(xd, XIVE_ESB_GET);
>  
> -		xmon_printf("PQ=%c%c",
> +		xmon_printf("flags=%c%c%c PQ=%c%c",
> +			    xd->flags & XIVE_IRQ_FLAG_STORE_EOI ? 'S' : ' ',
> +			    xd->flags & XIVE_IRQ_FLAG_LSI ? 'L' : ' ',
> +			    xd->flags & XIVE_IRQ_FLAG_H_INT_ESB ? 'H' : ' ',
>  			    val & XIVE_ESB_VAL_P ? 'P' : '-',
>  			    val & XIVE_ESB_VAL_Q ? 'Q' : '-');
>  	}