Re: [PATCH] ppc/spapr: Set the effective address provided flag in mc error log.

From: Mahesh J Salgaonkar <mahesh@linux.ibm.com>
To: Greg Kurz <groug@kaod.org>
Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, npiggin@gmail.com,
	ganeshgr@linux.ibm.com, qemu-ppc@nongnu.org,
	david@gibson.dropbear.id.au
Subject: Re: [PATCH] ppc/spapr: Set the effective address provided flag in mc error log.
Date: Wed, 18 Mar 2020 09:36:27 +0530	[thread overview]
Message-ID: <20200318040627.ywedm5aay3cllfzc@in.ibm.com> (raw)
In-Reply-To: <20200317171122.21c49c15@bahia.lan>

On 2020-03-17 17:11:22 Tue, Greg Kurz wrote:
> On Tue, 17 Mar 2020 08:51:50 -0700 (PDT)
> no-reply@patchew.org wrote:
> 
> > Patchew URL: https://patchew.org/QEMU/158444819283.31599.12155058652686614304.stgit@jupiter/
> > 
> > 
> > 
> > Hi,
> > 
> > This series seems to have some coding style problems. See output below for
> > more information:
> > 
> > Subject: [PATCH] ppc/spapr: Set the effective address provided flag in mc error log.
> > Message-id: 158444819283.31599.12155058652686614304.stgit@jupiter
> > Type: series
> > 
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> > git rev-parse base > /dev/null || exit 0
> > git config --local diff.renamelimit 0
> > git config --local diff.renames True
> > git config --local diff.algorithm histogram
> > ./scripts/checkpatch.pl --mailback base..
> > === TEST SCRIPT END ===
> > 
> > Switched to a new branch 'test'
> > 62d8ada ppc/spapr: Set the effective address provided flag in mc error log.
> > 
> > === OUTPUT BEGIN ===
> > ERROR: code indent should never use tabs
> > #57: FILE: hw/ppc/spapr_events.c:739:
> > +^Iswitch (ext_elog->mc.error_type) {$
> > 
> 
> Yeah no tabs allowed in the QEMU code (see CODING_STYLE.rst).
> 
> If your editor is emacs, you can consider setting these:
> 
>   (setq indent-tabs-mode nil)
>   (setq c-basic-offset 4))

My bad. Will fix it and respin v2.

Thanks,
-Mahesh.