From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Davide Caratti <dcaratti@redhat.com>
Cc: Saravana Kannan <saravanak@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Vladimir Benes <vbenes@redhat.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] driver core: Skip unnecessary work when device doesn't have sync_state()
Date: Wed, 25 Mar 2020 10:17:34 +0100 [thread overview]
Message-ID: <20200325091734.GA3073501@kroah.com> (raw)
In-Reply-To: <e1733a5fd6f6bbeeae82c0cbc62c17675818bb6c.camel@redhat.com>
On Wed, Mar 25, 2020 at 10:11:19AM +0100, Davide Caratti wrote:
> On Wed, 2020-03-25 at 08:44 +0100, Greg Kroah-Hartman wrote:
> > On Tue, Mar 24, 2020 at 09:03:28PM +0100, Davide Caratti wrote:
> > > On Fri, 2020-02-21 at 00:05 -0800, Saravana Kannan wrote:
> > > > A bunch of busy work is done for devices that don't have sync_state()
> > > > support. Stop doing the busy work.
> > > >
> > > > Signed-off-by: Saravana Kannan <saravanak@google.com>
> > > > ---
> > > > drivers/base/core.c | 4 +++-
> > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > >
> > > hello Greg,
> > >
> > > this patch and patch 2/3 of the same series proved to fix systematic
> > > crashes (NULL pointer dereference in device_links_flush_sync_list() while
> > > loading mac80211_hwsim.ko, see [1]) on Fedora 31, that are triggered by
> > > NetworkManager-ci [2]. May I ask to queue these two patches for the next
> > > 5.5 stable?
> >
> > What are the git commit ids of these patches in Linus's tree that you
> > want backported?
>
> right, I should have mentioned them also here:
>
> ac338acf514e "(driver core: Add dev_has_sync_state())" <-- patch 2/3
> 77036165d8bc "(driver core: Skip unnecessary work when device doesn't have sync_state())" <-- patch 3/3
>
> like Saravana mentioned, the problem is probably introduced by patch
> 1/3 of the series,
>
> 77036165d8bc "(driver core: Skip unnecessary work when device doesn't have sync_state())"
>
> that's already in stable 5.5.
Now queued up, thanks!
greg k-h
next prev parent reply other threads:[~2020-03-25 9:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 8:05 [PATCH v2 0/3] driver core: sync state fixups Saravana Kannan
2020-02-21 8:05 ` [PATCH v2 1/3] driver core: Call sync_state() even if supplier has no consumers Saravana Kannan
2020-02-21 9:25 ` Greg Kroah-Hartman
2020-02-21 9:48 ` Saravana Kannan
2020-02-21 10:32 ` Greg Kroah-Hartman
2020-02-21 16:00 ` Saravana Kannan
2020-02-21 8:05 ` [PATCH v2 2/3] driver core: Add dev_has_sync_state() Saravana Kannan
2020-02-21 8:05 ` [PATCH v2 3/3] driver core: Skip unnecessary work when device doesn't have sync_state() Saravana Kannan
2020-03-24 20:03 ` Davide Caratti
2020-03-24 20:14 ` Saravana Kannan
2020-03-25 7:44 ` Greg Kroah-Hartman
2020-03-25 9:11 ` Davide Caratti
2020-03-25 9:17 ` Greg Kroah-Hartman [this message]
2020-03-04 12:49 ` [PATCH v2 0/3] driver core: sync state fixups Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325091734.GA3073501@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dcaratti@redhat.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=vbenes@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.