From: Vadym Kochan <vadym.kochan@plvision.eu>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] selftests/net/forwarding: define libs as TEST_PROGS_EXTENDED
Date: Wed, 25 Mar 2020 12:26:33 +0200 [thread overview]
Message-ID: <20200325102633.GA6391@plvision.eu> (raw)
In-Reply-To: <20200325084101.9156-1-liuhangbin@gmail.com>
Hi Hangbin Liu,
On Wed, Mar 25, 2020 at 04:41:01PM +0800, Hangbin Liu wrote:
> The lib files should not be defined as TEST_PROGS, or we will run them
> in run_kselftest.sh.
>
> Also remove ethtool_lib.sh exec permission.
>
> Fixes: 81573b18f26d ("selftests/net/forwarding: add Makefile to install tests")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Thanks for fixing it, sorry for my mistake. Actually forwarding tests
requires interfaces list as runtime parameter or if it is defined in
forwarding.config file, so may be they should not run by run_kselftest
at all and only added via TEST_PROGS_EXTENDED ?
> ---
> .../testing/selftests/net/forwarding/Makefile | 31 ++++++++++---------
> .../selftests/net/forwarding/ethtool_lib.sh | 0
> 2 files changed, 16 insertions(+), 15 deletions(-)
> mode change 100755 => 100644 tools/testing/selftests/net/forwarding/ethtool_lib.sh
>
> diff --git a/tools/testing/selftests/net/forwarding/Makefile b/tools/testing/selftests/net/forwarding/Makefile
> index 44616103508b..250fbb2d1625 100644
> --- a/tools/testing/selftests/net/forwarding/Makefile
> +++ b/tools/testing/selftests/net/forwarding/Makefile
> @@ -5,11 +5,7 @@ TEST_PROGS = bridge_igmp.sh \
> bridge_sticky_fdb.sh \
> bridge_vlan_aware.sh \
> bridge_vlan_unaware.sh \
> - devlink_lib.sh \
> - ethtool_lib.sh \
> ethtool.sh \
> - fib_offload_lib.sh \
> - forwarding.config.sample \
> gre_inner_v4_multipath.sh \
> gre_inner_v6_multipath.sh \
> gre_multipath.sh \
> @@ -21,8 +17,6 @@ TEST_PROGS = bridge_igmp.sh \
> ipip_hier_gre_key.sh \
> ipip_hier_gre_keys.sh \
> ipip_hier_gre.sh \
> - ipip_lib.sh \
> - lib.sh \
> loopback.sh \
> mirror_gre_bound.sh \
> mirror_gre_bridge_1d.sh \
> @@ -32,15 +26,11 @@ TEST_PROGS = bridge_igmp.sh \
> mirror_gre_changes.sh \
> mirror_gre_flower.sh \
> mirror_gre_lag_lacp.sh \
> - mirror_gre_lib.sh \
> mirror_gre_neigh.sh \
> mirror_gre_nh.sh \
> mirror_gre.sh \
> - mirror_gre_topo_lib.sh \
> mirror_gre_vlan_bridge_1q.sh \
> mirror_gre_vlan.sh \
> - mirror_lib.sh \
> - mirror_topo_lib.sh \
> mirror_vlan.sh \
> router_bridge.sh \
> router_bridge_vlan.sh \
> @@ -50,17 +40,12 @@ TEST_PROGS = bridge_igmp.sh \
> router_multipath.sh \
> router.sh \
> router_vid_1.sh \
> - sch_ets_core.sh \
> sch_ets.sh \
> - sch_ets_tests.sh \
> - sch_tbf_core.sh \
> - sch_tbf_etsprio.sh \
> sch_tbf_ets.sh \
> sch_tbf_prio.sh \
> sch_tbf_root.sh \
> tc_actions.sh \
> tc_chains.sh \
> - tc_common.sh \
> tc_flower_router.sh \
> tc_flower.sh \
> tc_shblocks.sh \
> @@ -72,4 +57,20 @@ TEST_PROGS = bridge_igmp.sh \
> vxlan_bridge_1q.sh \
> vxlan_symmetric.sh
>
> +TEST_PROGS_EXTENDED := devlink_lib.sh \
> + ethtool_lib.sh \
> + fib_offload_lib.sh \
> + forwarding.config.sample \
> + ipip_lib.sh \
> + lib.sh \
> + mirror_gre_lib.sh \
> + mirror_gre_topo_lib.sh \
> + mirror_lib.sh \
> + mirror_topo_lib.sh \
> + sch_ets_core.sh \
> + sch_ets_tests.sh \
> + sch_tbf_core.sh \
> + sch_tbf_etsprio.sh \
> + tc_common.sh
> +
> include ../../lib.mk
> diff --git a/tools/testing/selftests/net/forwarding/ethtool_lib.sh b/tools/testing/selftests/net/forwarding/ethtool_lib.sh
> old mode 100755
> new mode 100644
> --
> 2.19.2
>
next prev parent reply other threads:[~2020-03-25 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 8:41 [PATCH net] selftests/net/forwarding: define libs as TEST_PROGS_EXTENDED Hangbin Liu
2020-03-25 10:26 ` Vadym Kochan [this message]
2020-03-25 13:37 ` Hangbin Liu
2020-03-25 19:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325102633.GA6391@plvision.eu \
--to=vadym.kochan@plvision.eu \
--cc=davem@davemloft.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.