Re: [PATCH 3/4] ARM: dts: exynos: Enable WLAN support for the Rinato board

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 3/4] ARM: dts: exynos: Enable WLAN support for the Rinato board
Date: Fri, 27 Mar 2020 13:24:10 +0100	[thread overview]
Message-ID: <20200327122410.GE7233@kozik-lap> (raw)
In-Reply-To: <20200326094626.28308-4-m.szyprowski@samsung.com>

On Thu, Mar 26, 2020 at 10:46:25AM +0100, Marek Szyprowski wrote:
> Add a node for BCM43342A SDIO chip on MSHC bus #1 and the required MMC
> power sequence node for the Exynos3250-based Rinato board.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos3250-rinato.dts | 36 +++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
> index 03f214089fd4..86fedccf277c 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -50,6 +50,11 @@
>  		};
>  	};
>  
> +	wlan_pwrseq: mshc1-pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		reset-gpios = <&gpe0 4 GPIO_ACTIVE_LOW>;
> +	};
> +
>  	i2c_max77836: i2c-gpio-0 {
>  		compatible = "i2c-gpio";
>  		gpios = <&gpd0 2 GPIO_ACTIVE_HIGH>, <&gpd0 3 GPIO_ACTIVE_HIGH>;
> @@ -625,6 +630,37 @@
>  	status = "okay";
>  };
>  
> +&mshc_1 {
> +	status = "okay";
> +
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	broken-cd;
> +	non-removable;

These two exclude each other. I guess it should be non-removable only.

Best regards,
Krzysztof

> +	cap-sd-highspeed;
> +	cap-sdio-irq;
> +	keep-power-in-suspend;
> +	card-detect-delay = <200>;
> +	samsung,dw-mshc-ciu-div = <1>;
> +	samsung,dw-mshc-sdr-timing = <0 1>;
> +	samsung,dw-mshc-ddr-timing = <1 2>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sd1_clk &sd1_cmd &sd1_bus1 &sd1_bus4>;
> +	bus-width = <4>;
> +
> +	mmc-pwrseq = <&wlan_pwrseq>;
> +
> +	brcmf: wifi@1 {
> +		compatible = "brcm,bcm4334-fmac";
> +		reg = <1>;
> +
> +		interrupt-parent = <&gpx1>;
> +		interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "host-wake";
> +	};
> +};
> +
>  &serial_0 {
>  	assigned-clocks = <&cmu CLK_SCLK_UART0>;
>  	assigned-clock-rates = <100000000>;
> -- 
> 2.17.1
> 